fix: rework app exit to account for running bots #9532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OEvgeny
force-pushed
the
fix/close-listeners
branch
from
b4e653d
to
503b1c5
Compare
OEvgeny
changed the title
sw-joelmut
previously approved these changes
Mar 14, 2023
OEvgeny
force-pushed
the
fix/close-listeners
branch
from
db16b51
to
690e40a
Compare
|
@OEvgeny there are conflicts on this PR now |
OEvgeny
force-pushed
the
fix/close-listeners
branch
from
7e9ee39
to
7dfd03b
Compare
|
@cwhitten updated, thanks! |
cwhitten
approved these changes
Apr 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reworks exit flow:
Task Item
fixes #9059
Screenshot