Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@OEvgeny
Copy link
Collaborator

@OEvgeny OEvgeny commented Mar 7, 2023

Description

This reworks exit flow:

  • Added exit indication and fixed client exit cycle (by @sw-joelmut)
  • Reworked server exit functionality to account for platform specifics and enforce proper exit (by @OEvgeny)

Task Item

fixes #9059

Screenshot

@OEvgeny OEvgeny force-pushed the fix/close-listeners branch from b4e653d to 503b1c5 Compare March 10, 2023 22:27
@OEvgeny OEvgeny marked this pull request as ready for review March 14, 2023 17:32
@OEvgeny OEvgeny changed the title fix: close server listeners upon app exit fix: rework app exit to account for running bots Mar 14, 2023
sw-joelmut
sw-joelmut previously approved these changes Mar 14, 2023
@coveralls
Copy link

coveralls commented Mar 15, 2023

Coverage Status

Coverage: 54.551% (-0.008%) from 54.559% when pulling 7dfd03b on OEvgeny:fix/close-listeners into efc9138 on microsoft:main.

@OEvgeny OEvgeny force-pushed the fix/close-listeners branch from db16b51 to 690e40a Compare April 11, 2023 20:18
@cwhitten
Copy link
Member

@OEvgeny there are conflicts on this PR now

@OEvgeny OEvgeny force-pushed the fix/close-listeners branch from 7e9ee39 to 7dfd03b Compare April 17, 2023 16:11
@OEvgeny
Copy link
Collaborator Author

OEvgeny commented Apr 17, 2023

@cwhitten updated, thanks!

@cwhitten cwhitten merged commit 39f01c2 into microsoft:main Apr 17, 2023
@OEvgeny OEvgeny deleted the fix/close-listeners branch April 18, 2023 02:26
@cwhitten cwhitten mentioned this pull request Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bot remains as a background process after closing Composer

4 participants