This repository was archived by the owner on Jul 9, 2025. It is now read-only.
Conversation
liweitian
requested review from
a-b-r-o-w-n,
boydc2014,
cwhitten and
luhan2017
as code owners
boydc2014
approved these changes
Aug 22, 2019
boydc2014
added a commit
that referenced
this pull request
Aug 23, 2019
* rename luPath to botDir * Move things from luIndexer to luPublisher * remove unused files interfaces * clean * clean up * remove invalid interface * update publish time after publish, instead of before * save after publish * move the length checking at later stage and rename some variables * simple test case is better than skiped tests * fix bugs and test cases and no longer add luis.status.json into this.files (#730) * fix some typos & grammar * don't muate the objects * handle comments (#735) * handle comments * fix test case * fix test cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
modify test cases and improve code readability
Task Item
Type of change
Please delete options that are not relevant.
Checklist
Screenshots
Please include screenshots or gifs if your PR include UX changes.