This repository was archived by the owner on Jul 9, 2025. It is now read-only.
Merged
Conversation
boydc2014
requested review from
a-b-r-o-w-n,
cwhitten and
luhan2017
as code owners
a-b-r-o-w-n
previously requested changes
Aug 21, 2019
Composer/packages/server/__tests__/models/bot/luisPublisher.test.ts
Outdated
Show resolved
Hide resolved
Composer/packages/server/__tests__/models/bot/luisPublisher.test.ts
Outdated
Show resolved
Hide resolved
cwhitten
previously requested changes
Aug 21, 2019
Composer/packages/server/__tests__/models/bot/luisPublisher.test.ts
Outdated
Show resolved
Hide resolved
| await this.luIndexer.flush(this.files, relativePath); | ||
| return this.luIndexer.getLuFiles(); | ||
|
|
||
| // TODO: valid before save |
Member
There was a problem hiding this comment.
s/valid/validate - will this happen in this change?
Contributor
Author
There was a problem hiding this comment.
no, this don't have validate before, so i don't include that work in this refactor, i will do that in another PR, i will create a validation interface for this, to consolidate the validation done for dialog\lu\lg.
Contributor
Author
|
@a-b-r-o-w-n Thanks for fixing the grammar and typos, i have a long way to go with my English :) |
* handle comments * fix test case * fix test cases
cwhitten
approved these changes
Aug 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As describe in this issues #716, recently changes into lu workflow add new features but break some interfaces and conventions. We need clean up and keep the code in a good shape before moving forward.
This refactor don't add\remove any feature. You can see, we -466 code, +155 code, and achieve the same thing in a more readable way. And enabled some tests, which is previously skipped.
Task Item
Please include the link to the related work item, like fix Something is not working
Type of change
Please delete options that are not relevant.
Checklist
Screenshots
Please include screenshots or gifs if your PR include UX changes.