This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: consume sdk.schema in Flow Action title#4455
Merged
cwhitten merged 4 commits intomicrosoft:mainfrom Oct 21, 2020
Merged
Conversation
yeze322
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
cwhitten
approved these changes
Oct 21, 2020
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* consume sdk.schema in ActionHeader to resolve the title * involve formConfig overrides Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #4405
closes #4281
Previously the title of an Action node is not aware of sdk.schema definitions.
This PR updates the implementation of title resolver to consume both sdk.schema and plugin options.
Meanwhile, the title priority issue mentioned in #4281 is also fixed here. Now $designer.name takes priority over title from sdk.
Task Item
Screenshots