Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: LUIS authoringKey used for endpoint calls instead of endpointKey #3165

Merged
cwhitten merged 4 commits into from
May 24, 2020
Merged

fix: LUIS authoringKey used for endpoint calls instead of endpointKey #3165

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d664245
send endpointkey to runtime
VanyLaw May 21, 2020
1a2f62d
Merge remote-tracking branch 'origin/master' into wenyluo/3145
VanyLaw May 22, 2020
79c5733
remove auth
VanyLaw May 22, 2020
167ed64
Merge branch 'master' into wenyluo/3145
cwhitten May 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions Composer/plugins/localPublish/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,14 +289,8 @@ class LocalPublisher implements PublishPlugin<PublishConfig> {
configList.push(config.MicrosoftAppPassword);
}
if (config.luis) {
if (config.luis.authoringKey) {
configList.push('--luis:endpointKey');
configList.push(config.luis.authoringKey);
}
if (config.luis.authoringRegion) {
Copy link
Member

@cwhitten cwhitten May 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this removed and it suggests that the --luis:endpoint is not necessary when the user supplies an authoringKey instead of endpointKey. Is this correct?

Copy link
Contributor Author

@VanyLaw VanyLaw May 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

endpoint is the URL base on luis region, it's not necessary because c# runtime will make it itself in builder.UseLuisConfigAdapter().UseLuisSettings() in Program.cs file (It's a feature of C# SDK).

configList.push('--luis:endpoint');
configList.push(`https://${config.luis.authoringRegion}.api.cognitive.microsoft.com`);
}
configList.push('--luis:endpointKey');
configList.push(config.luis.endpointKey || config.luis.authoringKey);
}
return configList;
};
Expand All @@ -320,18 +314,18 @@ class LocalPublisher implements PublishPlugin<PublishConfig> {
erroutput += err.toString();
});

child.on('exit', code => {
child.on('exit', (code) => {
if (code !== 0) {
reject(erroutput);
}
});

child.on('error', err => {
child.on('error', (err) => {
logger('error: %s', err.message);
reject(`Could not launch bot runtime process: ${err.message}`);
});

child.on('message', msg => {
child.on('message', (msg) => {
logger('%s', msg);
});
};
Expand All @@ -358,7 +352,7 @@ class LocalPublisher implements PublishPlugin<PublishConfig> {
}
archive.finalize();
output.on('close', () => resolve(dstPath));
output.on('error', err => {
output.on('error', (err) => {
reject(err);
});
});
Expand Down