This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: LUIS authoringKey used for endpoint calls instead of endpointKey#3165
Merged
fix: LUIS authoringKey used for endpoint calls instead of endpointKey#3165
Conversation
VanyLaw
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
corinagum,
cwhitten,
srinaath and
tonyanziano
as code owners
cwhitten
reviewed
May 22, 2020
| configList.push('--luis:endpointKey'); | ||
| configList.push(config.luis.authoringKey); | ||
| } | ||
| if (config.luis.authoringRegion) { |
Member
There was a problem hiding this comment.
I see this removed and it suggests that the --luis:endpoint is not necessary when the user supplies an authoringKey instead of endpointKey. Is this correct?
Contributor
Author
There was a problem hiding this comment.
endpoint is the URL base on luis region, it's not necessary because c# runtime will make it itself in builder.UseLuisConfigAdapter().UseLuisSettings() in Program.cs file (It's a feature of C# SDK).
cwhitten
approved these changes
May 24, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…microsoft#3165) * send endpointkey to runtime * remove auth Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pass endpointKey if exist to runtime.
Notice:
The endpointKey must bound with your luis application. Can bound in Luis portal like:
Otherwise, it will cause the 403 error.
Task Item
close #3145
Screenshots
endpointKey Resource will be call:
