Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

a11y: Add role project tree #2637

Merged
corinagum merged 8 commits into from
Apr 15, 2020
Merged

a11y: Add role project tree #2637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9789936
a11y: Add role and label to filter dialog and project tree
lei9444 Apr 14, 2020
fc7be31
Merge branch 'master' into fixa11y
lei9444 Apr 14, 2020
5e2c8c7
update the label name
lei9444 Apr 14, 2020
ff9d3cb
Merge branch 'master' into fixa11y
lei9444 Apr 15, 2020
c71c2ee
remove the label
lei9444 Apr 15, 2020
d351013
Merge branch 'master' into fixa11y
lei9444 Apr 15, 2020
9934532
Merge branch 'master' into fixa11y
lei9444 Apr 15, 2020
bfa071d
Merge branch 'master' into fixa11y
corinagum Apr 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Composer/packages/client/src/components/ProjectTree/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export const ProjectTree: React.FC<IProjectTreeProps> = props => {
onSelect(props.group!.key);
};
return (
<span ref={props.group && props.group.data.isRoot && addMainDialogRef}>
<span role="grid" ref={props.group && props.group.data.isRoot && addMainDialogRef}>
<TreeItem
link={props.group!.data}
depth={0}
Expand Down
5 changes: 4 additions & 1 deletion Composer/packages/client/src/components/ProjectTree/treeItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ interface ITreeItemProps {

const onRenderItem = (item: IOverflowSetItemProps) => {
return (
<div css={itemText(item.depth)}>
<div role="cell" css={itemText(item.depth)}>
{item.depth !== 0 && <Icon iconName="Flow" styles={{ root: { marginRight: '8px' } }} />}
{item.displayName}
</div>
Expand All @@ -32,6 +32,7 @@ const onRenderOverflowButton = (isRoot: boolean) => {
return overflowItems => {
return showIcon ? (
<IconButton
role="cell"
className="dialog-more-btn"
data-testid="dialogMoreButton"
styles={moreButton}
Expand All @@ -46,6 +47,7 @@ export const TreeItem: React.FC<ITreeItemProps> = props => {
const { link, isActive, isSubItemActive, depth, onDelete, onSelect } = props;
return (
<div
role="presentation"
tabIndex={1}
css={navItem(isActive, !!isSubItemActive)}
onClick={() => {
Expand All @@ -58,6 +60,7 @@ export const TreeItem: React.FC<ITreeItemProps> = props => {
}}
>
<OverflowSet
role="row"
items={[
{
key: link.id,
Expand Down