Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Comments

a11y: Add role project tree#2637

Merged
corinagum merged 8 commits intomicrosoft:masterfrom
lei9444:fixa11y
Apr 15, 2020
Merged

a11y: Add role project tree#2637
corinagum merged 8 commits intomicrosoft:masterfrom
lei9444:fixa11y

Conversation

@lei9444
Copy link
Contributor

@lei9444 lei9444 commented Apr 14, 2020

Description

image

Task Item

refs #2016

Screenshots

Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2016 looks good!
#2054 behavior is not fixed yet.

Previously, the narrator would say 'Filter dialog. Search box. Filter dialog'
Now, the narrator says 'Search box. Search box. Filter dialog'

@lei9444
Copy link
Contributor Author

lei9444 commented Apr 15, 2020

#2016 looks good!
#2054 behavior is not fixed yet.

Previously, the narrator would say 'Filter dialog. Search box. Filter dialog'
Now, the narrator says 'Search box. Search box. Filter dialog'

Hi @corinagum I have removed the aria-label in searchbox, so this PR only fix #2016 now. I will create a new PR #2653 to fix #2054

@lei9444 lei9444 changed the title a11y: Add role and label to filter dialog and project tree a11y: Add role project tree Apr 15, 2020
@corinagum corinagum merged commit b67799a into microsoft:master Apr 15, 2020
@lei9444 lei9444 deleted the fixa11y branch May 9, 2020 00:38
lei9444 added a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* a11y: Add role and label to filter dialog and project tree

* update the label name

* remove the label

Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants