Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

chore: update lu/lg all up view - #1806

Merged
Andy Brown (a-b-r-o-w-n) merged 13 commits into
masterfrom
liweitian/updateAllupView
Jan 9, 2020
Merged

chore: update lu/lg all up view#1806
Andy Brown (a-b-r-o-w-n) merged 13 commits into
masterfrom
liweitian/updateAllupView

Conversation

@liweitian

@liweitian liweitian commented Dec 25, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

update lu/lg all up view UX

Task Item

Closes #822

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have functionally tested my change

Screenshots

3333

@github-actions

github-actions Bot commented Dec 25, 2019

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.06%) to 42.913% when pulling 11e69ba on liweitian/updateAllupView into 52c46aa on master.

@boydc2014

Dong Lei (boydc2014) commented Dec 27, 2019

Copy link
Copy Markdown
Contributor

Zhixiang Zhan (@zhixzhan) can you help review this first?

zhixzhan
Zhixiang Zhan (zhixzhan) previously requested changes Dec 27, 2019
View reviewed changes
Comment thread Composer/packages/client/src/pages/language-generation/index.tsx Outdated
Comment thread Composer/packages/client/src/pages/language-generation/index.tsx
Comment thread Composer/packages/client/src/pages/language-generation/index.tsx Outdated
Comment thread Composer/packages/client/src/pages/language-understanding/index.tsx Outdated
Comment thread Composer/packages/client/src/pages/language-understanding/styles.js Outdated
Comment thread Composer/packages/client/src/pages/language-understanding/styles.js Outdated
zhixzhan
Zhixiang Zhan (zhixzhan) reviewed Dec 27, 2019
View reviewed changes
Comment thread Composer/cypress/integration/LGPage.spec.ts Outdated
@zhixzhan

Zhixiang Zhan (zhixzhan) commented Dec 27, 2019

Copy link
Copy Markdown
Contributor

To keep /microsoft/BotFramework-Composer clean, we should develop and PR from our own forking repository, like Andy previously mentioned here.
https://github.com/microsoft/BotFramework-Composer/blob/stable/CONTRIBUTING.md#forking

@lei9444

leileizhang (lei9444) commented Dec 31, 2019

Copy link
Copy Markdown
Contributor

all
There is a bug when refresh or go back. we should get the id from the URL.

@liweitian
liweitian force-pushed the liweitian/updateAllupView branch 2 times, most recently from 1dc5a18 to 74c0771 Compare January 6, 2020 06:00
yeze322
zeye (yeze322) reviewed Jan 7, 2020
View reviewed changes
Comment thread Composer/packages/client/src/pages/language-generation/index.tsx Outdated
yeze322
zeye (yeze322) reviewed Jan 7, 2020
View reviewed changes
Comment thread Composer/packages/client/src/pages/language-generation/index.tsx Outdated
yeze322
zeye (yeze322) reviewed Jan 7, 2020
View reviewed changes
Comment thread Composer/packages/client/src/pages/language-generation/index.tsx Outdated
yeze322
zeye (yeze322) reviewed Jan 7, 2020
View reviewed changes
Comment thread Composer/packages/client/src/pages/language-understanding/index.tsx Outdated
yeze322
zeye (yeze322) reviewed Jan 7, 2020
View reviewed changes
Comment thread Composer/packages/client/src/pages/language-understanding/index.tsx Outdated
yeze322
zeye (yeze322) reviewed Jan 7, 2020
View reviewed changes
Comment thread Composer/packages/client/src/pages/language-understanding/index.tsx Outdated
@yeze322

zeye (yeze322) commented Jan 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

liweitian Left some comments on code quality, we can make small improvements

(sorry I clicked on the 'closed' button)

@yeze322 zeye (yeze322) reopened this Jan 7, 2020
@boydc2014

Dong Lei (boydc2014) commented Jan 7, 2020

Copy link
Copy Markdown
Contributor

liweitian Left some comments on code quality, we can make small improvements

(sorry I clicked on the 'closed' button)

Thanks zeye (@yeze322) , I think Zhixiang Zhan (@zhixzhan) should also take a look for those comments and advises, see if we can optimize some internal structure in this PR. If some points is valid but requires a bigger change, it's OK to mark an issue and solve it in next batch.

@liweitian
liweitian force-pushed the liweitian/updateAllupView branch from 74c0771 to 9d3a56b Compare January 7, 2020 12:18
boydc2014
Dong Lei (boydc2014) approved these changes Jan 9, 2020
View reviewed changes

@boydc2014 Dong Lei (boydc2014) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me after several rounds of review, let's wait till Chris Whitten (@cwhitten) and Andy Brown (@a-b-r-o-w-n) has a chance to look at.

@a-b-r-o-w-n
Andy Brown (a-b-r-o-w-n) merged commit 30c03bb into master Jan 9, 2020
@a-b-r-o-w-n
Andy Brown (a-b-r-o-w-n) deleted the liweitian/updateAllupView branch January 9, 2020 18:47
@a-b-r-o-w-n Andy Brown (a-b-r-o-w-n) mentioned this pull request Jan 27, 2020
Merged
Chris Whitten (cwhitten) added a commit that referenced this pull request Jan 28, 2020
@cwhitten
release: 01-27-2020
028775b 
### 01-27-2020

#### Added

- feat: enrich prebuilt memory paths and add user defined memory paths ([#1868](#1868)) ([@lei9444](https://github.com/lei9444))
- feat: Language-Understanding LSP ([#1711](#1711)) ([@cosmicshuai](https://github.com/cosmicshuai))
- feat: lu shell api ([#1810](#1810)) ([@zhixzhan](https://github.com/zhixzhan))
- feat: Start Botproject runtime in bot folder ([#1672](#1672)) ([@VanyLaw](https://github.com/VanyLaw))
- feat: Schema-driven visual editor - migrates 15 simple types ([#1811](#1811)) ([@yeze322](https://github.com/yeze322))
- feat: Update OnConversationUpdate actions ([#1794](#1794)) ([@luhan2017](https://github.com/luhan2017))
- feat: Update LG and built in expression functions in LSP ([#1790](#1790)) ([@Danieladu](https://github.com/Danieladu))
- feat: Add dynamic choices to Choice Prompt ([#1777](#1777)) ([@tdurnford](https://github.com/tdurnford))
- feat: update ui for new schema ([#1775](#1775)) ([@alanlong9278](https://github.com/alanlong9278))
- feat: lu all up view ux enhancement ([#1879](#1879)) ([@zhixzhan](https://github.com/zhixzhan))
- feat: add autoClosingPairs for lg editor ([#1789](#1789)) ([@cosmicshuai](https://github.com/cosmicshuai))

#### Fixed

- fix: update the lg content to store when editor editing ([#1884](#1884)) ([@lei9444](https://github.com/lei9444))
- fix: Aligned elements in prompt settings ([#1893](#1893)) ([@tdurnford](https://github.com/tdurnford))
- fix: remove label from validations ([#1891](#1891)) ([@tdurnford](https://github.com/tdurnford))
- fix: Undo / redo behavior on LG resources ([#1813](#1813)) ([@lei9444](https://github.com/lei9444))
- fix: botproject build script powershell version limit ([#1857](#1857)) ([@VanyLaw](https://github.com/VanyLaw))
- fix: Add support of auto suggestion memory variable ([#1819](#1819)) ([@cosmicshuai](https://github.com/cosmicshuai))
- fix: Fixed Multiple Choice Type undo/redo functionality ([#1844](#1844)) ([@tdurnford](https://github.com/tdurnford))
- fix: RepeatDialog not shown ([#1835](#1835)) ([@yeze322](https://github.com/yeze322))
- fix: do not preset name when creating a dialog ([#1805](#1805)) ([@liweitian](https://github.com/liweitian))
- fix: luis authoringRegion not update in popup form ([#1818](#1818)) ([@VanyLaw](https://github.com/VanyLaw))
- fix: Check all expressions in dialog ([#1798](#1798)) ([@lei9444](https://github.com/lei9444))
- fix: TextWidget hover ([#1825](#1825)) ([@tdurnford](https://github.com/tdurnford))
- fix: Create bot from scratch may create a non-empty bot ([#1796](#1796)) ([@liweitian](https://github.com/liweitian))
- fix: Updated release version on about page ([#1788](#1788)) ([@tdurnford](https://github.com/tdurnford))
- fix: Remove the unused lufiles in notifications ([#1760](#1760)) ([@lei9444](https://github.com/lei9444))
- fix: update form correctly when undo or redo changes ([#1808](#1808)) ([@lei9444](https://github.com/lei9444))
- fix: handle multiple ctrl+z in lg editor ([#1804](#1804)) ([@zhixzhan](https://github.com/zhixzhan))

#### Changed

- refactor: re-provide `getLgTemplates` api ([#1746](#1746)) ([@yeze322](https://github.com/yeze322))
- style: updated delete icon ([#1892](#1892)) ([@tdurnford](https://github.com/tdurnford))
- refactor: let ElementWrapper control the focus state ([#1880](#1880)) ([@yeze322](https://github.com/yeze322))
- refactor: render Elements with composition strategy (ElementRenderer -> ElementWrapper) ([#1873](#1873)) ([@yeze322](https://github.com/yeze322))

#### Other

- chore: migrate IfCondition, SwitchCondition, Foreach(Page) to uischema ([#1899](#1899)) ([@yeze322](https://github.com/yeze322))
- chore: migrate TextInput and all other \*Input types to uischema ([#1874](#1874)) ([@yeze322](https://github.com/yeze322))
- chore: migrate SendActivity, BeginDialog, ReplaceDialog to uischema ([#1840](#1840)) ([@yeze322](https://github.com/yeze322))
- chore: retire 'DefaultRenderer' in visual editor ([#1836](#1836)) ([@yeze322](https://github.com/yeze322))
- chore: update lu/lg all up view ([#1806](#1806)) ([@liweitian](https://github.com/liweitian))
- chore: share server's resource to lsp server ([#1793](#1793)) ([@zhixzhan](https://github.com/zhixzhan))
- chore: refactor lg page route & url ([#1756](#1756)) ([@zhixzhan](https://github.com/zhixzhan))
- chore: convert ludown to bf-lu ([#1608](#1608)) ([@lei9444](https://github.com/lei9444))
- chore: proxy lsp ws request in dev ([#1754](#1754)) ([@zhixzhan](https://github.com/zhixzhan))
- docs: fix a typo ([#1901](#1901)) ([@HiltonGiesenow](https://github.com/HiltonGiesenow))
- docs: use correct link in events and triggers documentation ([#1832](#1832)) ([@arafattehsin](https://github.com/arafattehsin))
- docs: fix memory documentation link and typo ([#1833](#1833)) ([@arafattehsin](https://github.com/arafattehsin))
- docs: fix the links to intents and advanced definitions ([#1854](#1854)) ([@arafattehsin](https://github.com/arafattehsin))
- chore: bump immer to 5.2.0 ([#1846](#1846)) ([@cwhitten](https://github.com/cwhitten))
- chore: update botproject packages ([#1809](#1809)) ([@luhan2017](https://github.com/luhan2017))
- chore: update github templates ([@a-b-r-o-w-n](https://github.com/a-b-r-o-w-n))
- chore: update schema and samples ([@luhan2017](https://github.com/luhan2017))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@a-b-r-o-w-n Andy Brown (a-b-r-o-w-n) Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner
@cwhitten Chris Whitten (cwhitten) Awaiting requested review from cwhitten cwhitten is a code owner
4 more reviewers
@yeze322 zeye (yeze322) yeze322 left review comments
@lei9444 leileizhang (lei9444) lei9444 left review comments
@zhixzhan Zhixiang Zhan (zhixzhan) zhixzhan left review comments
@boydc2014 Dong Lei (boydc2014) boydc2014 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@liweitian @boydc2014 @zhixzhan @lei9444 @yeze322 @a-b-r-o-w-n