fix: Check all expressions in dialog by lei9444 · Pull Request #1798 · microsoft/BotFramework-Composer

leileizhang (lei9444) · 2019-12-23T17:40:45Z

Description

Check array in the dialog.
add specific check function for some types: 'Microsoft.ChoiceInput'.

Task Item

Closes #1783
Closes #1822

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Code refactor (non-breaking change which improve code quality, clean up, add tests, etc)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Doc update (document update)

Checklist

I have added tests that prove my fix is effective or that my feature works
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have functionally tested my change

Screenshots

github-actions · 2019-12-25T07:45:11Z

Coverage increased (+0.01%) to 42.868% when pulling 7a4ef0c on lei9444:fixcheck into 52c46aa on microsoft:master.

…mposer-1 into fixcheck * 'fixcheck' of https://github.com/lei9444/BotFramework-Composer-1: update the schema commit -m change the checkfun structure

…mposer-1 into fixcheck * 'fixcheck' of https://github.com/lei9444/BotFramework-Composer-1: update local data when data change out the form (microsoft#1808)

…mposer-1 into fixcheck

@lei9444

### 01-27-2020 #### Added - feat: enrich prebuilt memory paths and add user defined memory paths ([#1868](#1868)) ([@lei9444](https://github.com/lei9444)) - feat: Language-Understanding LSP ([#1711](#1711)) ([@cosmicshuai](https://github.com/cosmicshuai)) - feat: lu shell api ([#1810](#1810)) ([@zhixzhan](https://github.com/zhixzhan)) - feat: Start Botproject runtime in bot folder ([#1672](#1672)) ([@VanyLaw](https://github.com/VanyLaw)) - feat: Schema-driven visual editor - migrates 15 simple types ([#1811](#1811)) ([@yeze322](https://github.com/yeze322)) - feat: Update OnConversationUpdate actions ([#1794](#1794)) ([@luhan2017](https://github.com/luhan2017)) - feat: Update LG and built in expression functions in LSP ([#1790](#1790)) ([@Danieladu](https://github.com/Danieladu)) - feat: Add dynamic choices to Choice Prompt ([#1777](#1777)) ([@tdurnford](https://github.com/tdurnford)) - feat: update ui for new schema ([#1775](#1775)) ([@alanlong9278](https://github.com/alanlong9278)) - feat: lu all up view ux enhancement ([#1879](#1879)) ([@zhixzhan](https://github.com/zhixzhan)) - feat: add autoClosingPairs for lg editor ([#1789](#1789)) ([@cosmicshuai](https://github.com/cosmicshuai)) #### Fixed - fix: update the lg content to store when editor editing ([#1884](#1884)) ([@lei9444](https://github.com/lei9444)) - fix: Aligned elements in prompt settings ([#1893](#1893)) ([@tdurnford](https://github.com/tdurnford)) - fix: remove label from validations ([#1891](#1891)) ([@tdurnford](https://github.com/tdurnford)) - fix: Undo / redo behavior on LG resources ([#1813](#1813)) ([@lei9444](https://github.com/lei9444)) - fix: botproject build script powershell version limit ([#1857](#1857)) ([@VanyLaw](https://github.com/VanyLaw)) - fix: Add support of auto suggestion memory variable ([#1819](#1819)) ([@cosmicshuai](https://github.com/cosmicshuai)) - fix: Fixed Multiple Choice Type undo/redo functionality ([#1844](#1844)) ([@tdurnford](https://github.com/tdurnford)) - fix: RepeatDialog not shown ([#1835](#1835)) ([@yeze322](https://github.com/yeze322)) - fix: do not preset name when creating a dialog ([#1805](#1805)) ([@liweitian](https://github.com/liweitian)) - fix: luis authoringRegion not update in popup form ([#1818](#1818)) ([@VanyLaw](https://github.com/VanyLaw)) - fix: Check all expressions in dialog ([#1798](#1798)) ([@lei9444](https://github.com/lei9444)) - fix: TextWidget hover ([#1825](#1825)) ([@tdurnford](https://github.com/tdurnford)) - fix: Create bot from scratch may create a non-empty bot ([#1796](#1796)) ([@liweitian](https://github.com/liweitian)) - fix: Updated release version on about page ([#1788](#1788)) ([@tdurnford](https://github.com/tdurnford)) - fix: Remove the unused lufiles in notifications ([#1760](#1760)) ([@lei9444](https://github.com/lei9444)) - fix: update form correctly when undo or redo changes ([#1808](#1808)) ([@lei9444](https://github.com/lei9444)) - fix: handle multiple ctrl+z in lg editor ([#1804](#1804)) ([@zhixzhan](https://github.com/zhixzhan)) #### Changed - refactor: re-provide `getLgTemplates` api ([#1746](#1746)) ([@yeze322](https://github.com/yeze322)) - style: updated delete icon ([#1892](#1892)) ([@tdurnford](https://github.com/tdurnford)) - refactor: let ElementWrapper control the focus state ([#1880](#1880)) ([@yeze322](https://github.com/yeze322)) - refactor: render Elements with composition strategy (ElementRenderer -> ElementWrapper) ([#1873](#1873)) ([@yeze322](https://github.com/yeze322)) #### Other - chore: migrate IfCondition, SwitchCondition, Foreach(Page) to uischema ([#1899](#1899)) ([@yeze322](https://github.com/yeze322)) - chore: migrate TextInput and all other \*Input types to uischema ([#1874](#1874)) ([@yeze322](https://github.com/yeze322)) - chore: migrate SendActivity, BeginDialog, ReplaceDialog to uischema ([#1840](#1840)) ([@yeze322](https://github.com/yeze322)) - chore: retire 'DefaultRenderer' in visual editor ([#1836](#1836)) ([@yeze322](https://github.com/yeze322)) - chore: update lu/lg all up view ([#1806](#1806)) ([@liweitian](https://github.com/liweitian)) - chore: share server's resource to lsp server ([#1793](#1793)) ([@zhixzhan](https://github.com/zhixzhan)) - chore: refactor lg page route & url ([#1756](#1756)) ([@zhixzhan](https://github.com/zhixzhan)) - chore: convert ludown to bf-lu ([#1608](#1608)) ([@lei9444](https://github.com/lei9444)) - chore: proxy lsp ws request in dev ([#1754](#1754)) ([@zhixzhan](https://github.com/zhixzhan)) - docs: fix a typo ([#1901](#1901)) ([@HiltonGiesenow](https://github.com/HiltonGiesenow)) - docs: use correct link in events and triggers documentation ([#1832](#1832)) ([@arafattehsin](https://github.com/arafattehsin)) - docs: fix memory documentation link and typo ([#1833](#1833)) ([@arafattehsin](https://github.com/arafattehsin)) - docs: fix the links to intents and advanced definitions ([#1854](#1854)) ([@arafattehsin](https://github.com/arafattehsin)) - chore: bump immer to 5.2.0 ([#1846](#1846)) ([@cwhitten](https://github.com/cwhitten)) - chore: update botproject packages ([#1809](#1809)) ([@luhan2017](https://github.com/luhan2017)) - chore: update github templates ([@a-b-r-o-w-n](https://github.com/a-b-r-o-w-n)) - chore: update schema and samples ([@luhan2017](https://github.com/luhan2017))

check all expressions in dialog

129807d

leileizhang (lei9444) requested review from Andy Brown (a-b-r-o-w-n), Dong Lei (boydc2014) and Chris Whitten (cwhitten) as code owners December 23, 2019 17:40

leileizhang (lei9444) added 9 commits December 24, 2019 01:42

update the schema"

3e535fc

update schema

716d4ec

Merge branch 'master' into fixcheck

0ee6ae5

check items in schema

944b273

navigation

b262a69

update the fragment function

3bf8dae

move convert function to client

9ff6938

fix unit test

0dd2282

update the diagnostic path

7a4ef0c

Dong Lei (boydc2014) suggested changes Dec 27, 2019

View reviewed changes

Comment thread Composer/packages/lib/indexers/src/dialogIndexer.ts Outdated

leileizhang (lei9444) and others added 11 commits December 27, 2019 16:31

commit -m change the checkfun structure

58fdb72

update the schema

bc17a5a

expression regx

b1d0344

Merge branch 'fixcheck' of https://github.com/lei9444/BotFramework-Co…

954bc4c

…mposer-1 into fixcheck * 'fixcheck' of https://github.com/lei9444/BotFramework-Composer-1: update the schema commit -m change the checkfun structure

ui adjust for assignment property in setProperties

478be0b

Merge branch 'master' into fixcheck

7ca6362

fix e2e bug

b8ecd88

fix the array copy error

f022292

Merge branch 'master' into fixcheck

0ba0f19

sync expression error in formEditor

24d83dc

Merge branch 'fixcheck' of https://github.com/lei9444/BotFramework-Co…

686c152

…mposer-1 into fixcheck * 'fixcheck' of https://github.com/lei9444/BotFramework-Composer-1: update local data when data change out the form (microsoft#1808)

Chris Whitten (cwhitten) suggested changes Dec 30, 2019

View reviewed changes

leileizhang (lei9444) added 3 commits December 31, 2019 14:54

fix some comments

b3a73b8

Merge branch 'fixcheck' of https://github.com/lei9444/BotFramework-Co…

a0fd9c3

…mposer-1 into fixcheck

Merge branch 'master' into fixcheck

8b6395f

leileizhang (lei9444) added 5 commits December 31, 2019 17:07

move diagnostic path to shell

89998e0

Merge branch 'fixcheck' of https://github.com/lei9444/BotFramework-Co…

9d7b8f9

…mposer-1 into fixcheck

fix unit test

512c567

update shared and indexers

0ccc90d

fix spell error

26a967d

leileizhang (lei9444) added the Needs review label Jan 3, 2020

Merge branch 'master' into fixcheck

011e3ae

Dong Lei (boydc2014) removed the Needs review label Jan 6, 2020

Merge branch 'master' into fixcheck

c898ae0

Chris Whitten (cwhitten) approved these changes Jan 6, 2020

View reviewed changes

Chris Whitten (cwhitten) merged commit 7bd7409 into microsoft:master Jan 6, 2020

This was referenced Jan 6, 2020

[Linting & Validation] expression fields in arrays do not get validated #1783

Closed

Small bug in Set properties description #1822

Closed

leileizhang (lei9444) deleted the fixcheck branch January 17, 2020 07:59

Andy Brown (a-b-r-o-w-n) mentioned this pull request Jan 27, 2020

release: 01-27-2020 #1910

Merged

Navigation Menu

Uh oh!

fix: Check all expressions in dialog - #1798

fix: Check all expressions in dialog#1798
Chris Whitten (cwhitten) merged 31 commits into
microsoft:masterfrom
lei9444:fixcheck

leileizhang (lei9444) commented Dec 23, 2019 •

edited

Loading

Uh oh!

github-actions Bot commented Dec 25, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

leileizhang (lei9444) commented Dec 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Task Item

Type of change

Checklist

Screenshots

Uh oh!

github-actions Bot commented Dec 25, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

leileizhang (lei9444) commented Dec 23, 2019 •

edited

Loading