Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Conversation

@JasonSowers
Copy link
Contributor

Fixes

line 44 in TokenExchangeHelper.cs should throw if the type is not equal to SignInConstants.TokenExchangeOperationName instead of equal to.

Proposed Changes

Change to not equals instead of equals. have verified with @EricDahlvang

line 44 in `TokenExchangeHelper.cs` should throw if the type is not equal to `SignInConstants.TokenExchangeOperationName` instead of equal to.
@JasonSowers JasonSowers requested a review from a team as a code owner January 20, 2021 00:07
Copy link
Member

@EricDahlvang EricDahlvang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JasonSowers !

@EricDahlvang EricDahlvang merged commit 7c93006 into microsoft:main Jan 20, 2021
@Ravi-Macha
Copy link

@JasonSowers - If I log out also, still bot answers my question. I have opened the Microsoft case- 2104200010010965

@JasonSowers
Copy link
Contributor Author

JasonSowers commented May 21, 2021

@JasonSowers - If I log out also, still bot answers my question. I have opened the Microsoft case- 2104200010010965

@Ravi-Macha
Did you post an issue in this repo? That is the best thing to do on the bot builder side. Unfortunately I changed jobs and do not have the project I worked on to refer to and test.

@Ravi-Macha
Copy link

@JasonSowers - Got it, Thank you. Yes I have opened the Bug- #3289

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants