Bot Answers even after Logout

[Ravi-Macha]

Github issues for C# /JS / Java/ Python should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.

Sample information

https://github.com/microsoft/BotBuilder-Samples/tree/main/experimental/teams-sso/csharp_dotnetcore

1. Sample type: BotBuilder-Samples/experimental/teams-sso/csharp_dotnetcore/
2. Sample language: dotnetcore
3. Sample name: csharp_dotnetcore

Describe the bug

Give a clear and concise description of what the bug is.

To Reproduce

Steps to reproduce the behavior:

1. Login
2. It opens the It opens Oauth Permissions
3. Enter/Provide the permission (Continue)
4. Login successful
5. Search for any text after overriding the OnMessageActivityAsync method
6. Bot will answer
7. Type logout
8. Again search for anything Bot will answer first

Expected behavior

After logout Bot should not answer any questions

Screenshots

Additional context

I have opened the Microsoft ticket -2104200010010965 and I am available to connect during CST time.

[stevkan]

@Ravi-Macha, you suggest you are overriding the OnMessageActivityAsync() method. Can you provide that code? I suspect the problem is there.

Testing the sample as-is results in it functioning as expected - I can login, communicate with the bot by viewing my token, and log out. After logging out, the bot requests me to sign in again before allowing me to do anything else.

[Ravi-Macha]

@stevkan @ryanlengel Sure, I am just calling some sample method from OnMessageActivityAsync(). Even I did not find the way to check the user token present in session context(turnContext) after Logout.

When user enters "logout" In logoutDialog class we are removing user details by
await botAdapter.SignOutUserAsync(innerDc.Context, ConnectionName, null, cancellationToken);

    protected override async Task OnMessageActivityAsync(ITurnContext<IMessageActivity> turnContext, CancellationToken cancellationToken)
    {
        _logger.LogInformation("Running dialog with Message Activity.");
        
        await ProcessUserMessageAsync(turnContext, cancellationToken);
        await _dialogManager.OnTurnAsync(turnContext, cancellationToken);
    }


    private async Task ProcessUserMessageAsync(ITurnContext<IMessageActivity> turnContext, CancellationToken cancellationToken){
      var userState = _userState.GetCachedState(turnContext);
     var text = turnContext.Activity.Text.ToLowerInvariant();
      _logger.LogInformation($"ProcessUserMessageAsync method USER-TEXT ===============  : {text}.");
        var tenantId = (string)turnContext.Activity.Conversation.TenantId;
         _logger.LogInformation($"ProcessUserMessageAsync method TENANT ID ===============  : {tenantId}.");

        if (tenantId != null)
        {
         _logger.LogInformation("================== TENANT ID NOT NULL ============== ");
          if(text.IndexOf("ecc") >=0){
            await turnContext.SendActivityAsync(MessageFactory.Text($"Here is your Abc Page Url https://abc.com"), cancellationToken);
          }else if(text.IndexOf("azure") >=0){
            await turnContext.SendActivityAsync(MessageFactory.Text($"Here is your Azure Page Url https://azure.com"), cancellationToken);
          }else if(text.IndexOf("iam") >=0){
            await turnContext.SendActivityAsync(MessageFactory.Text($"Here is your Iam Page Url https://iam.com"), cancellationToken);
          }
        }
       //await _dialogManager.OnTurnAsync(turnContext, cancellationToken);
       //await turnContext.SendActivityAsync(MessageFactory.Text($"No Results Found .. Sorry"), cancellationToken);
    }

[JasonSowers]

@Ravi-Macha mentioned me in my PR #3035 so i'm trying to help if i can. There is a lot going on here to get this sample working and i understand the frustration when trying to get it running for the first time. I was I struggled to get this sample working at first myself. The assignee @stevkan is super knowledgeable and an awesome person, but is probably working on a million things right now.

I tested and ran the sample successfully. So unfortunately, I have nothing useful to add in regards to a fix.

I would check your configurations of your Auth application in Azure and double check your keys, callbacks urls, and secrets everywhere they are used. Some useful resources might be this doc and This walkthrough although I am pretty sure you have already seen them, sharing just in case. Another thing I would try is Starting with just the sample and no additional code and see if that works for you. If it does start adding in your customized code one thing at a time to see where it breaks. If it doesn't work there is most likely an issue with the configurations on your AAD app in Azure, or some other configuration.

If you are able to and willing to share your code, I can take a look when I have time as well. Just put it in a private repo and add me as a collaborator, or if you wish i can make a private repo for you and give you access and permission to delete it if that is easier for you.

[Ravi-Macha]

@JasonSowers @stevkan My code is same as - code I have not modified anything other than adding one extra personal method. I have mentioned in above post. Thank you for looking in to this issue.

[stevkan]

Hi @Ravi-Macha, thank you for your patience. Testing the sample in question continues to work as expected. The bot allows me to sign in, view my token, and sign out. Without being signed in, it requests me to do so. When replacing OnMessageActivityAsync() with your code, the bot also still works as expected.

Are you able to post how you setup your OAuth (without including any pertinent details like keys, secrets, etc.)? I see in your last image that you are being prompted to grant permissions, as well.

[Ravi-Macha]

@stevkan I have just fallowed the steps provided here - Steps Configure.

Also I have attached the Image which I have configured for Bot channel Registration. Let me know if you need steps of AAD configuration also.