Skip to content

Shopify: UX confusing error message when creating credit memo #5097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Shopify: UX confusing error message when creating credit memo #5097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d499ff3
AB#609501 Shopify: Clarify error message for credit memo creation fro…
AndreiPanko Oct 8, 2025
687f6da
Update src/Apps/W1/Shopify/App/src/Order Refunds/Codeunits/ShpfyRefun…
AndreiPanko Oct 8, 2025
283485c
Update src/Apps/W1/Shopify/Test/Order Refunds/ShpfyOrderRefundTest.Co…
AndreiPanko Oct 8, 2025
5c88e79
Update src/Apps/W1/Shopify/App/src/Order Refunds/Codeunits/ShpfyRefun…
AndreiPanko Oct 9, 2025
4e76818
Update error message for credit memo creation
AndreiPanko Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Apps/W1/Shopify/App/src/Order Refunds/Codeunits/ShpfyRefundsAPI.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ codeunit 30228 "Shpfy Refunds API"
CommunicationMgt: Codeunit "Shpfy Communication Mgt.";
JsonHelper: Codeunit "Shpfy Json Helper";
RefundEnumConvertor: Codeunit "Shpfy Refund Enum Convertor";
RefundCantCreateCreditMemoErr: Label 'The refund imported from Shopify can''t be used to create a credit memo. Only refunds for paid items can be used to create credit memos.';
RefundCantCreateCreditMemoErr: Label 'This refund cannot be used to create a credit memo because it has already been considered during order import and reduced the quantity and amounts of the order. Only refunds with a non-zero refunded amount and related to real item returns can be used to create credit memos.';

internal procedure GetRefunds(JRefunds: JsonArray)
var
Expand Down
2 changes: 1 addition & 1 deletion src/Apps/W1/Shopify/Test/Order Refunds/ShpfyOrderRefundTest.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ codeunit 139611 "Shpfy Order Refund Test"
asserterror RefundsAPI.VerifyRefundCanCreateCreditMemo(RefundId3);

// [THEN] Only RefundId3 throws an error
LibraryAssert.ExpectedError('The refund imported from Shopify can''t be used to create a credit memo. Only refunds for paid items can be used to create credit memos.');
LibraryAssert.ExpectedError('This refund cannot be used to create a credit memo because it has already been considered during order import and reduced the quantity and amounts of the order. Only refunds with a non-zero refunded amount and related to real item returns can be used to create credit memos.');
end;

[Test]
Expand Down
Loading