Shopify: UX confusing error message when creating credit memo #5097
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m refund and update related test.\n\n- Updated error message in ShpfyRefundsAPI.Codeunit.al to clarify when a refund cannot be used to create a credit memo.\n- Updated test in ShpfyOrderRefundTest.Codeunit.al to expect the new error message.
onbuyuka
reviewed
Oct 8, 2025
src/Apps/W1/Shopify/App/src/Order Refunds/Codeunits/ShpfyRefundsAPI.Codeunit.al
Outdated
Show resolved
Hide resolved
src/Apps/W1/Shopify/Test/Order Refunds/ShpfyOrderRefundTest.Codeunit.al
Outdated
Show resolved
Hide resolved
…dsAPI.Codeunit.al Co-authored-by: Onat Buyukakkus <55088871+onbuyuka@users.noreply.github.com>
…deunit.al Co-authored-by: Onat Buyukakkus <55088871+onbuyuka@users.noreply.github.com>
onbuyuka
previously approved these changes
Oct 8, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR updates a confusing error message related to Shopify refund processing to provide clearer guidance to users when a refund cannot be used to create a credit memo.
- Updated error message text in ShpfyRefundsAPI codeunit to be more descriptive and explanatory
- Updated corresponding test assertion to expect the new error message
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ShpfyRefundsAPI.Codeunit.al | Updated error message label to provide more detailed explanation of why refunds cannot create credit memos |
| ShpfyOrderRefundTest.Codeunit.al | Updated test assertion to expect the new, more descriptive error message |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/Apps/W1/Shopify/App/src/Order Refunds/Codeunits/ShpfyRefundsAPI.Codeunit.al
Outdated
Show resolved
Hide resolved
…dsAPI.Codeunit.al Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
onbuyuka
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated error message in ShpfyRefundsAPI.Codeunit.al to clarify when a refund cannot be used to create a credit memo.
Updated test in ShpfyOrderRefundTest.Codeunit.al to expect the new error message.
Work Item(s)
Fixes # AB#609501