-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Application Insights ASP.NET Core SDK by default reads application's IConfiguration and all properties of ApplicationInsightsServiceOptions from configuration #1850
Conversation
Get changes from develop
…fields of ApplicationInsightsServiceOptions
NETCORE/src/Shared/Extensions/ApplicationInsightsServiceOptions.cs
Outdated
Show resolved
Hide resolved
@cijothomas friendly reminder, please put this PR at the top of your todo list. |
Yup. Will review this shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Raj. Looks good.
Requesting a minor (but important) change:
-
We need to test the WorkerService as well. It was already reading IConfiguration from user, but was never binding it to AIServiceOptions. Now, we added binding. But this portion is not tested.
-
Please set 30 mins so we can do a manual testing with this PR. Unit tests should cover everything, but this is significantly huge so we can afford to spend some time manual testing together.
…osoft/ApplicationInsights-dotnet into rajrang/aspnetconfiguration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Raj!
Lets open an new issue in Github to describe the new behavior. This PR is addressing a bunch of issues, so its easy if we have a new issue just describing the exact change, and have it linked in changelog.md.
Addressing Issue: #1882
Changes
DefaultApplicationInsightsServiceConfigureOptions.cs
to inject IConfiguration from an application and added the same to configurationbuilderApplicationInsightsExtensions.cs
to bind configuration values toApplicationInsightsServiceConfigureOptions
Checklist
For significant contributions please make sure you have completed the following items:
The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.
Notes for authors:
Notes for reviewers:
/AzurePipelines run
will queue all builds/AzurePipelines run <pipeline-name>
will queue a specific build