Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Insights ASP.NET Core SDK by default reads application's IConfiguration and all properties of ApplicationInsightsServiceOptions from configuration #1850

Merged
merged 15 commits into from
May 29, 2020

Conversation

rajkumar-rangaraj
Copy link
Member

@rajkumar-rangaraj rajkumar-rangaraj commented May 4, 2020

Addressing Issue: #1882

Changes

  • Modified DefaultApplicationInsightsServiceConfigureOptions.cs to inject IConfiguration from an application and added the same to configurationbuilder
  • Modified ApplicationInsightsExtensions.cs to bind configuration values to ApplicationInsightsServiceConfigureOptions

Checklist

  • I ran Unit Tests locally.
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed

The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.

Notes for authors:

  • FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.

Notes for reviewers:

  • We support comment build triggers
    • /AzurePipelines run will queue all builds
    • /AzurePipelines run <pipeline-name> will queue a specific build

@TimothyMothra TimothyMothra added this to the 2.15 milestone May 5, 2020
@TimothyMothra
Copy link
Member

@cijothomas friendly reminder, please put this PR at the top of your todo list.

@cijothomas
Copy link
Contributor

@cijothomas friendly reminder, please put this PR at the top of your todo list.

Yup. Will review this shortly.

Copy link
Contributor

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Raj. Looks good.
Requesting a minor (but important) change:

  1. We need to test the WorkerService as well. It was already reading IConfiguration from user, but was never binding it to AIServiceOptions. Now, we added binding. But this portion is not tested.

  2. Please set 30 mins so we can do a manual testing with this PR. Unit tests should cover everything, but this is significantly huge so we can afford to spend some time manual testing together.

Copy link
Contributor

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Raj!
Lets open an new issue in Github to describe the new behavior. This PR is addressing a bunch of issues, so its easy if we have a new issue just describing the exact change, and have it linked in changelog.md.

@rajkumar-rangaraj rajkumar-rangaraj merged commit e6635a2 into develop May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants