Configuration issue with AzureKeyVault

[Yalpe]

Hi,

I noticed a difference in behavior in our docker services when configuring ApplicationInsights InstrumentationKey in a KeyVault using Microsoft.Extensions.Configuration.AzureKeyVault:

ServiceA (WorkerService)
ServibeB (AspNetCore)

The InstrumentationKey is null in appsettings.json and fetched from a KeyVault in our environments. The result is this:

ServiceA can fetch the Instrumentation key using this configuration:
public void ConfigureServices(IServiceCollection services) { services.AddApplicationInsightsTelemetry(); }

ServiceB can not fetch the Instrumentation key using this initialization:
public void ConfigureServices(IServiceCollection services) { services.AddApplicationInsightsTelemetry(); }

ServiceB can fetch the Instrumentation key using this initialization:
public void ConfigureServices(IServiceCollection services) { services.AddApplicationInsightsTelemetry(this.Configuration); }

Now I'm not that knowledgeable with dotnet core configurations yet but I think the problem comes from this line

ApplicationInsights-dotnet/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/Extensions/DefaultApplicationInsightsServiceConfigureOptions.cs

Line 31 in d331966

var configBuilder = new ConfigurationBuilder()

. I assume that since its not using my configuration object I have to force the code to configure the options by passing in the Configuration object

ApplicationInsights-dotnet/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/Extensions/ApplicationInsightsExtensions.cs

Line 67 in d331966

services.AddApplicationInsightsTelemetry(options => AddTelemetryConfiguration(configuration, options));

.

If I compare the code to the WorkerService, I noticed that the IConfiguration is injected instead.

ApplicationInsights-dotnet/NETCORE/src/Microsoft.ApplicationInsights.WorkerService/DefaultApplicationInsightsServiceConfigureOptions.cs

Line 21 in d331966

public DefaultApplicationInsightsServiceConfigureOptions(IConfiguration configuration = null)

Could this be why the behavior is different?

[cijothomas]

This is known limitation of Asp.Net Core projects - it doesn't look at user IConfiguration for ikey.
Worker service SDK does this.

But this is being addressed already, and should be available the next beta version.
cc: @rajkumar-rangaraj

[cijothomas]

@Yalpe - Btw your analysis is fully correct! thanks for spending time here, and hopefully no other customers would have to spend time on this, as we;ll have a fix for this very soon!

[cijothomas]

will be closed by this PR by @rajkumar-rangaraj #1850