Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Fix FxCop violations #182

Merged
merged 1 commit into from
Apr 30, 2018
Merged

Fix FxCop violations #182

merged 1 commit into from
Apr 30, 2018

Conversation

pharring
Copy link
Member

@pharring pharring commented Apr 29, 2018 •
edited
Loading

CA1307 Use StringComparison.Ordinal for StartsWith
CA1063 Seal classes with trivial Dispose methods
CA1305 Use InvariantCulture for ToString and string.Format
CA1309 Use ordinal comparison
CA1507 Use nameof
CA1801 Review unused parameters
CA1823 Remove unused fields
CA1825 Avoid zero length array allocations
CA2007 Call ConfigureAwait

@pharring
Fix FxCop violations
e2db934 
CA1037 Use StringComparison.Ordinal for StartsWith
CA1063 Seal classes with trivial Dispose methods
CA1305 Use InvariantCulture for ToString and string.Format
CA1309 Use ordinal comparison
CA1507 Use nameof
CA1801 Review unused parameters
CA1823 Remove unused fields
CA1825 Avoid zero length array allocations
CA2007 Call ConfigureAwait
@pharring
Copy link
Member Author

See #162
This isn't all of them, but it's a good chunk.

@pharring
Copy link
Member Author

Ready to merge.
@SergeyKanzhelev or @MS-TimothyMothra please merge for me (I don't have write access to this repo)

@pharring pharring closed this Apr 30, 2018
@pharring pharring reopened this Apr 30, 2018
@SergeyKanzhelev SergeyKanzhelev merged commit fb8df1a into microsoft:develop Apr 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TimothyMothra TimothyMothra TimothyMothra approved these changes

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pharring @SergeyKanzhelev @TimothyMothra