add fxcop analyzer

[TimothyMothra]

Add the FxCop Analyzer to Non-Test projects.

This analyzer identifies SEVERAL compiler errors.
If you're bored one afternoon, feel free to pull this branch and fix a couple! :)

[SergeyKanzhelev]

@MS-TimothyMothra this approach never works. I'd suggest merge fixes as you go. So you will not end up with enormous merge conflict in a few weeks.

[TimothyMothra]

@SergeyKanzhelev I'm open to suggestions for a better approach.
I thought this might be the easiest for the whole team to contribute to.

Across all our repos there are over 700 errors. It will almost certainly be required to resolve these before our next SDL review. We can discuss more offline.

[SergeyKanzhelev]

I'm suggesting to send fixes in separate PRs and merge them as you making them. Like you did 3 fixes - send them as a separate PR. Perhaps this may be a good instruction:

git checkout -b fxcop/feelBraveToday
git cherry-pick 9801d05246043bf99bccd7d336573601541460e3

... 
do the fixes
...

git revert <cherry-pick commit ID>
git push

Maybe fixing everything in one PR will also work as this repo has low traffic overall.

Thanks again for starting it! 👍

[TimothyMothra]

Only 4 remaining issues.

@SergeyKanzhelev this is ready to be reviewed.
When @Dmitry-Matveev gets back, I want to discuss if we should wait to merge this with a Beta1 release.

[TimothyMothra]

@Dmitry-Matveev this is a medium PR. :)

[SergeyKanzhelev]

do you have work item for this so we wouldn't forget?

[SergeyKanzhelev]

this is default as I understand. Why you need it explicitly?

[TimothyMothra]

This was inserted by default. I haven't tested without.

[SergeyKanzhelev]

I'd suggest to remove to avoid confusion