-
Notifications
You must be signed in to change notification settings - Fork 5
Hook ObservabilityBuilder to use new configuration provider #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds first-class support for supplying an IConfigurationProvider<ObservabilityConfiguration> to ObservabilityBuilder (and threading it into exporter/logger configuration), enabling configuration overrides without relying solely on environment variables.
Changes:
- Add
configProvidersupport toObservabilityBuilder(builder option + chaining method) and pass it through toAgent365ExporterOptionsandDefaultLogger. - Thread
configProviderfromObservabilityManager.start()into the builder. - Expand unit tests to validate provider-overrides for exporter toggles/domain overrides and builder plumbing.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/observability/tracing/exporter-utils.test.ts | Adds test coverage to ensure exporter util toggles honor an explicit configProvider override. |
| tests/observability/core/observabilityBuilder-configProvider.test.ts | New tests validating builder chaining, exporter options propagation, and logger selection behavior with configProvider. |
| packages/agents-a365-observability/src/tracing/exporter/Agent365ExporterOptions.ts | Extends exporter options with optional configProvider for observability configuration lookups. |
| packages/agents-a365-observability/src/tracing/exporter/Agent365Exporter.ts | Uses the provided configProvider when resolving custom domain and domain override behavior. |
| packages/agents-a365-observability/src/ObservabilityManager.ts | Passes configProvider from start() options into the builder. |
| packages/agents-a365-observability/src/ObservabilityBuilder.ts | Adds withConfigurationProvider() and threads the provider into exporter enablement checks, exporter options, and default logger construction. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Hook ObservabilityBuilder to use new configuration provider.
The configuration for PerRequestProcessor is in separated PR.