Skip to content

Conversation

@fpfp100
Copy link
Contributor

@fpfp100 fpfp100 commented Feb 11, 2026

Hook ObservabilityBuilder to use new configuration provider.
The configuration for PerRequestProcessor is in separated PR.

Copilot AI review requested due to automatic review settings February 11, 2026 18:35
@fpfp100 fpfp100 requested a review from a team as a code owner February 11, 2026 18:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds first-class support for supplying an IConfigurationProvider<ObservabilityConfiguration> to ObservabilityBuilder (and threading it into exporter/logger configuration), enabling configuration overrides without relying solely on environment variables.

Changes:

  • Add configProvider support to ObservabilityBuilder (builder option + chaining method) and pass it through to Agent365ExporterOptions and DefaultLogger.
  • Thread configProvider from ObservabilityManager.start() into the builder.
  • Expand unit tests to validate provider-overrides for exporter toggles/domain overrides and builder plumbing.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/observability/tracing/exporter-utils.test.ts Adds test coverage to ensure exporter util toggles honor an explicit configProvider override.
tests/observability/core/observabilityBuilder-configProvider.test.ts New tests validating builder chaining, exporter options propagation, and logger selection behavior with configProvider.
packages/agents-a365-observability/src/tracing/exporter/Agent365ExporterOptions.ts Extends exporter options with optional configProvider for observability configuration lookups.
packages/agents-a365-observability/src/tracing/exporter/Agent365Exporter.ts Uses the provided configProvider when resolving custom domain and domain override behavior.
packages/agents-a365-observability/src/ObservabilityManager.ts Passes configProvider from start() options into the builder.
packages/agents-a365-observability/src/ObservabilityBuilder.ts Adds withConfigurationProvider() and threads the provider into exporter enablement checks, exporter options, and default logger construction.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings February 11, 2026 18:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

@fpfp100 fpfp100 self-assigned this Feb 11, 2026
threddy
threddy previously approved these changes Feb 11, 2026
@threddy threddy self-requested a review February 11, 2026 23:33
@fpfp100 fpfp100 merged commit 0a67776 into main Feb 12, 2026
7 checks passed
@fpfp100 fpfp100 deleted the users/pefan/configProvider-observability branch February 12, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants