-
Notifications
You must be signed in to change notification settings - Fork 111
Bug fixes. Add support enum annotations #791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixes. Add support enum annotations #791
Conversation
|
Could you bump the minor snapshot version? Upgrading to new minors requires a minor version bump |
|
@graemerocher Sure. Done |
|
@graemerocher Could you merge these changes and relese them? Want to use javadoc parser on field level, but withut these changes it doesnt wotk :-( |
Fix wrong logic for property name when used Schema and JsonProperty annotations (fix #787) Fix field javadoc properties parsing. Fix invalid defaultValue and allowValues types (have always been String) Upgrade libs: Micronaut 3.6.0 Gradle 7.5.1 Groovy 3.0.12
|
@altro3 Not sure if this is related, however I upgrade from Micronaut 3.4.1 -> 3.6.1 just now and in 3.4.1 the Swagger generated the .yml properly with Enum examples using the @Shchema annotation. In 3.4.1 I had the following However, after upgrading to Micronaut 3.6.1 I started to see this And after some testing I had to remove all defaultValue I had defined in my @Schema for ENUMs to fix above issue. In the PR above you mention Why is it always added as null to the yaml file? I believe default values was working properly as strings previously? |
|
@JouperCoding Hi! Ok, got it. I'll check it on the weekend |
|
@JouperCoding fixed it in this PR |
|
Sorry for the delay, was on vacation |
|
@graemerocher No problem. I realized that you have a vacation according to the statistics of your activity in github ;-) |
@JsonPropertyname ignored in OpenAPI metadata when@Schemapresent as well #787)examplefield with null value (always addedexample: nullto yaml file)required: falsefield in final yaml fileMicronaut 3.6.1
Gradle 7.5.1
Groovy 3.0.12