Added support for enum values with JsonProperty annotation #730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+1373
to
+1387
| private List<String> getEnumValues(EnumElement type) { | ||
| List<String> enumValues = new ArrayList<>(); | ||
| javax.lang.model.element.Element nativeType = (javax.lang.model.element.Element) type.getNativeType(); | ||
| for (javax.lang.model.element.Element element : nativeType.getEnclosedElements()) { | ||
| if (element.getKind() == ElementKind.ENUM_CONSTANT) { | ||
| JsonProperty jsonproperty = element.getAnnotation(JsonProperty.class); | ||
| if (jsonproperty != null && StringUtils.hasText(jsonproperty.value())) { | ||
| enumValues.add(jsonproperty.value()); | ||
| } else { | ||
| enumValues.add(element.getSimpleName().toString()); | ||
| } | ||
| } | ||
| } | ||
| return enumValues; | ||
| } |
There was a problem hiding this comment.
This change will only work on Java, we prefer to not have direct dependencies on the javax.lang.model api. Can you alter this to use EnumElement and the values() method is already offers. This possibly will require a change in core.
There was a problem hiding this comment.
@graemerocher Hmm... if this method cannot be used - then yes, you will have to modify the kernel. Because now it is possible to get only a list of values, without annotations (Ivan described the problem in the issue). In general, need to add a method to EnumElement that will return a list of values and their annotations
…port for different enum types and default value. Fixed #471
|
Fixed here: #791 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #471