-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge 3.9.x, fix TCK test and document breakage #9133
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bump micronaut-micrometer to 4.8.3 * micrometer to 1.10.5 --------- Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> see: https://netty.io/news/2023/04/03/4-1-91-Final.html
* added management to gradle * added health indicator config * added indicator factory * added unit tests * updated test and added to service discovery manual * removed dependency and updated version to 3.9 * moved indicator to management module, removed health-indicator config in favor of config under endpoints * revert change to lib * changed to compileonly and added additional config requirement in indicator * removed factory and references
…/examples to use ConversionService bean. (#8695) * Deprecate `ConversionService.SHARED` and update custom converter docs/examples to use ConversionService bean. closes #8620 * build: Micronaut Build Plugins to 5.4.3 * build plugin to 5.4.6 --------- Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com>
…the class one (#8608) * fix: Load ApplicationContextConfigurer with passed classloader instead of the class one * test: Add test for loading ApplicationContextConfigurer with passed class loader
* bug: SslConfiguration::setProtocol * test: Deflake the BinaryWebSocketSpec (#8725) --------- Co-authored-by: Tim Yates <tim.yates@gmail.com>
--------- Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com>
This fails in 4.0.0 as the response is OK
timyates
commented
Apr 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what this is...
dstepanov
approved these changes
Apr 20, 2023
graemerocher
approved these changes
Apr 20, 2023
Bah... I chose poorly and lost https://github.com/micronaut-projects/micronaut-core/pull/9105/files Working... |
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documents the breaking change discovered by #9132
I think I resolved the conflicts ok, but can people take a quick look and make sure