Add targetPackage property to the @Introspected annotation #9105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graemerocher
requested changes
Apr 14, 2023
| * @since 3.9.0 | ||
| */ | ||
| @Experimental | ||
| String introspectionPackage() default ""; |
There was a problem hiding this comment.
rename to targetPackage
| @@ -180,6 +180,8 @@ private void processIntrospected(ClassElement element, VisitorContext context, A | |||
| Introspected.AccessKind[] accessKinds = introspected.enumValues("accessKind", Introspected.AccessKind.class); | |||
| Introspected.Visibility[] visibilities = | |||
| introspected.enumValues("visibility", Introspected.Visibility.class); | |||
| final String introspectionPackage = introspected.stringValue("introspectionPackage").orElse(element.getPackageName()); | |||
There was a problem hiding this comment.
If this package names differ we need to change the default visibility to only public members (see Visibility.PUBLIC) since package private and protected members will no longer be visible from different packages. In the 4.0.x branch we support reflection as a fall back but not here.
andriy-dmytruk
changed the title
|
@andriy-dmytruk should I move this PR to ready for review? |
graemerocher
approved these changes
Apr 17, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The property can be used in the following manner:
This can be used when
SomeClasswas built externally but the class was processed by an annotation processor as sources to create introspection metadata (and avoid "signer information does not match signer information of other classes in the same package" error). It can be also used in combination with theclassesproperty of the annotation.