Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression where AliasFor is no longer recursive #8746

Merged
merged 7 commits into from
Feb 17, 2023
Merged

Fix regression where AliasFor is no longer recursive #8746

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0201f9a
fix replaces regression
graemerocher Feb 9, 2023
4977541
Fix recursive alias for
dstepanov Feb 15, 2023
07919aa
Correct merge
dstepanov Feb 16, 2023
12087a0
Correct tests
dstepanov Feb 16, 2023
99f8b5f
Correct tests
dstepanov Feb 16, 2023
bbb4e44
Improve fix
graemerocher Feb 16, 2023
5181c34
revert logger change
graemerocher Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Correct tests
  • Loading branch information
@dstepanov
dstepanov committed Feb 16, 2023
commit 99f8b5ff1cb76d33257c39947a0c2d4e899a0ba6
2 changes: 1 addition & 1 deletion ...essor/src/main/java/io/micronaut/inject/annotation/AbstractAnnotationMetadataBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,7 @@ private void processAnnotationAlias(Map<CharSequence, Object> annotationValues,
introducedAnnotations.add(newAnnotation);
ProcessedAnnotation newNewAnnotation = processAliases(newAnnotation, introducedAnnotations);
if (newNewAnnotation != newAnnotation) {
introducedAnnotations.add(introducedAnnotations.indexOf(newAnnotation), newNewAnnotation);
introducedAnnotations.set(introducedAnnotations.indexOf(newAnnotation), newNewAnnotation);
}
}
}
Expand Down
1 change: 1 addition & 0 deletions inject-java/src/test/groovy/io/micronaut/visitors/ClassElementSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ package io.micronaut.visitors

import io.micronaut.annotation.processing.test.AbstractTypeElementSpec
import io.micronaut.annotation.processing.visitor.JavaClassElement
import io.micronaut.context.annotation.Replaces
import io.micronaut.context.exceptions.BeanContextException
import io.micronaut.core.annotation.AnnotationUtil
import io.micronaut.core.annotation.Introspected
Expand Down