Fix regression where AliasFor is no longer recursive #8746
Conversation
|
❌ GraalVM CE CI 17 latest failed: https://ge.micronaut.io/s/ntcstfy6qfwik |
|
❌ GraalVM CE CI 17 latest failed: https://ge.micronaut.io/s/r5ccy7u7jvg3o |
|
❌ GraalVM CE CI 19 dev failed: https://ge.micronaut.io/s/dkdmvr22sl77e |
|
❌ Java CI failed: https://ge.micronaut.io/s/tqslbfujwyufg |
dstepanov
force-pushed
the
replaces-regression
branch
from
317225a to
07919aa
Compare
|
❌ Java CI failed: https://ge.micronaut.io/s/qmhhexg3jayci |
|
❌ GraalVM CE CI 17 latest failed: https://ge.micronaut.io/s/i765czrjfvpri |
| @@ -37,7 +37,7 @@ class MyBean { | |||
| beanDefinition.getInjectedMethods()[0].name == 'setMyValue' | |||
| def metadata = beanDefinition.getInjectedMethods()[0].getAnnotationMetadata() | |||
| metadata.hasAnnotation(Property) | |||
| metadata.getValue(Property, "name", String).get() == 'endpoints.my-value' | |||
| metadata.getValue(Property, "name", String).get() == 'simple.my-value' | |||
There was a problem hiding this comment.
Both tests are "testing" the broken functionality of ConfigurationReader where the value can be aliased multiple times incorrectly, correct use-case is for TestEndpoint1 to use base value.
|
❌ GraalVM CE CI 17 latest failed: https://ge.micronaut.io/s/3ko5tq6aiy7ze |
|
❌ Java CI failed: https://ge.micronaut.io/s/c7jypklo2or5u |
graemerocher
changed the title
|
Kudos, SonarCloud Quality Gate passed! |
The Micronaut Test module is failing because bean replacements are not working correctly. It seems to be a regression in the way
@AliasForis processed since the change here works around the issue.