codal_port/microbit_soundeffect: Use CODAL-provided constants for fx. #218
Commits on Aug 22, 2024
-
codal_app/microbithal: Add sound effect default constants.
Signed-off-by: Damien George <damien@micropython.org>
-
codal_port/microbit_soundeffect: Add comments for CODAL fx constants.
It's not possible to include the CODAL header file that defines these constants because that header file is C++. Signed-off-by: Damien George <damien@micropython.org>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.