codal_port/microbit_soundeffect: Use CODAL-provided constants for fx. #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgeorge
force-pushed
the
microbit-soundeffect-update-default-fx-constants
branch
from
a0ac7dd
to
6eb46a3
Compare
|
Thanks Damien! |
Signed-off-by: Damien George <damien@micropython.org>
It's not possible to include the CODAL header file that defines these constants because that header file is C++. Signed-off-by: Damien George <damien@micropython.org>
dpgeorge
force-pushed
the
microbit-soundeffect-update-default-fx-constants
branch
from
6eb46a3
to
251bd63
Compare
|
Updated to add static asserts. |
microbit-carlos
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address #155 (comment)
Edit: It's not possible to include the CODAL header file that defines these constants because that header file is C++. So instead just add comments.