Update get_data notebook in runtime documentation to use napa style identifiers
#598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 15, 2024 14:28
1 task
aclum
reviewed
Jul 17, 2024
aclum
reviewed
Jul 17, 2024
docs/nb/get_data.ipynb
Outdated
| @@ -503,7 +490,7 @@ | |||
| "\n", | |||
| " return local_filename\n", | |||
| "\n", | |||
| "id_biosample = \"igsn:IEWFS000A\"\n", | |||
| "id_biosample = \"igsn:IEWFS000A\" #UPDATE\n", | |||
There was a problem hiding this comment.
Suggested change
| "id_biosample = \"igsn:IEWFS000A\" #UPDATE\n", | |
| "id_biosample = \"nmdc:bsm-11-mbnqn650\"\n", |
There was a problem hiding this comment.
The new ID for igsn:IEWFS000A is nmdc:bsm-11-mbnqn650
aclum
reviewed
Oct 21, 2024
| " 'id': 'nmdc:839560f9650622f232c262d8cf7a9db9',\n", | ||
| " 'started_at_time': '2022-05-31T12:26:24-07:00',\n", | ||
| " 'type': 'nmdc:MetatranscriptomeAssembly'}]\n" | ||
| "\n" |
There was a problem hiding this comment.
@PeopleMakeCulture can you remove this keyboard interruption text?
|
@PeopleMakeCulture do you have time to revisit this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates documentation notebook to use napa style identifiers
Fixes user research issue #34
Type of change
How Has This Been Tested?
All cells ran successfully on local jupyter server
Configuration Details: none
Definition of Done (DoD) Checklist:
A simple checklist of necessary activities that add verifiable/demonstrable value to the product by asserting the quality of a feature, not the functionality of that feature; the latter should be stated as acceptance criteria in the issue this PR closes. Not all activities in the PR template will be applicable to each feature since the definition of done is intended to be a comprehensive checklist. Consciously decide the applicability of value-added activities on a feature-by-feature basis.
black nmdc_runtime/?)docs/and in https://github.com/microbiomedata/NMDC_documentation/?)make up-test && make test-run)