fix: ensure pydantic models serialize to json-compatible dicts.
#346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add regression test closes #345
eecavanna
approved these changes
Nov 2, 2023
|
I recommend holding off on merging this until there is no risk of such a merge complicating the resolution of issue #348. |
| ) | ||
| doc = drs_obj.dict(exclude_unset=True) | ||
| doc = drs_obj.model_dump(exclude_unset=True, mode="json") |
There was a problem hiding this comment.
I don't think order matters functionally, but this is stylistically inconsistent with the rest of the codebase
PeopleMakeCulture
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
approved with one none-blocking style comment. Waiting on resolution of #348 to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add regression test
closes #345
replaces many instances of pydantic-model-to-dict calls (
.dict(...)) with.model_dump(mode="json",...)calls as per pydantic V2 guidance.