-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add groups #7
Merged
Merged
Add groups #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intent is that excluded fields remain unchanged by the command. This should make it so a client does not need to keep as much state to make a request
This needs further testing. However testing needs to be simplified before adding more tests will make sense
@micronova-jb Just make sure the changes in api.py make sense for groups, I'm working on your updates in another branch |
micronova-jb
approved these changes
Oct 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Looking forward to merging with my branch!
jonahshader
pushed a commit
that referenced
this pull request
May 9, 2023
added notifications for update and no network connection
SteveMicroNova
pushed a commit
that referenced
this pull request
May 9, 2024
# This is the 1st commit message: Add very basic user manual Still need to explore how to integrate latex commands invisibly # This is the commit message #2: Small layout updates before adding images # This is the commit message #3: Add a bunch of images # This is the commit message #4: Add Jason suggestions # This is the commit message #5: Cleanup wire image # This is the commit message #6: wip # This is the commit message #7: Seperate the manual into seperate files This avoids needing to add page breaks into the markdown and makes most of the peices reusable. Things like the controller specs can be linked individually. # This is the commit message #8: Add troubleshooting section # This is the commit message #9: Write initial updated manual (DRAFT FOR REVIEW) # This is the commit message #10: Update "Developing on a separate computer" section of DEVELOPING.md # This is the commit message #11: Update BLUETOOTH.md to have useful info for a printed format # This is the commit message #12: Add docker-compose.yaml Edit for reviewer inputs # This is the commit message #13: Edit for reviewer input # This is the commit message #14: Comment out SVGs, generate PDF for copy-editing # This is the commit message #15: Remove EDIT EDIT EDIT Replace QR codes # This is the commit message #16: Replace main unit panel images Stylize title, correct date on front page # This is the commit message #17: Correct formatting in TROUBLESHOOTING.md Remove incorrect information about the back panel from MAIN_CONTROLLER.md
SteveMicroNova
pushed a commit
that referenced
this pull request
May 9, 2024
# This is the 1st commit message: Add very basic user manual Still need to explore how to integrate latex commands invisibly # This is the commit message #2: Small layout updates before adding images # This is the commit message #3: Add a bunch of images # This is the commit message #4: Add Jason suggestions # This is the commit message #5: Cleanup wire image # This is the commit message #6: wip # This is the commit message #7: Seperate the manual into seperate files This avoids needing to add page breaks into the markdown and makes most of the peices reusable. Things like the controller specs can be linked individually. # This is the commit message #8: Add troubleshooting section # This is the commit message #9: Write initial updated manual (DRAFT FOR REVIEW) # This is the commit message #10: Update "Developing on a separate computer" section of DEVELOPING.md # This is the commit message #11: Update BLUETOOTH.md to have useful info for a printed format # This is the commit message #12: Add docker-compose.yaml Edit for reviewer inputs # This is the commit message #13: Edit for reviewer input # This is the commit message #14: Comment out SVGs, generate PDF for copy-editing # This is the commit message #15: Remove EDIT EDIT EDIT Replace QR codes # This is the commit message #16: Replace main unit panel images Stylize title, correct date on front page # This is the commit message #17: Correct formatting in TROUBLESHOOTING.md Remove incorrect information about the back panel from MAIN_CONTROLLER.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add group support to EthAudio and basic tests of groups