Update groups #14
Merged
Update groups #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… enclosed array ie. 'zones' : '[1,2,3]'
This is just temporary to simplify the group interface
For now it still is a fixed volume for each zone. This is only temporary until the android app matches our expectations
This should help us debug group support
We need to ignore some changes in the test for group aggregates to pass
…r zones Added flag to ignore group changes since they can be generated aggregate properties, This is needed when changing a zone's volume, since a group's volume is calculated from its zones. Not all tests should need. Fixed underlying diff test to make most comparisons by individual fields, this was breaking bow that many fields were added to groups
micronova-jb
approved these changes
Nov 5, 2020
Yup |
Merged
ephnielsondev
approved these changes
Nov 7, 2020
linknum23
added a commit
that referenced
this pull request
Nov 16, 2020
Save group, zone, and source configurations so that they can be reused. - Made saving robust to basic file corruption and added tests for fallback cases - Miscellaneous bug fixes found while testing with android app - Move testing back into single file - Added sample configuration of Jason's house - Note: this needs to be merged after #14
linknum23
added a commit
that referenced
this pull request
Jan 25, 2021
Add various changes to update the api and make group support more robust + Make pretty printed output for full api status (including groups) + Add flags to make testing configuration easier for Ephraim and Jeremy + Add group fields that are aggregates of their zone properties to ensure a uniform implementation of group handling
linknum23
added a commit
that referenced
this pull request
Jan 25, 2021
Save group, zone, and source configurations so that they can be reused. - Made saving robust to basic file corruption and added tests for fallback cases - Miscellaneous bug fixes found while testing with android app - Move testing back into single file - Added sample configuration of Jason's house - Note: this needs to be merged after #14
SteveMicroNova
pushed a commit
that referenced
this pull request
May 9, 2024
# This is the 1st commit message: Add very basic user manual Still need to explore how to integrate latex commands invisibly # This is the commit message #2: Small layout updates before adding images # This is the commit message #3: Add a bunch of images # This is the commit message #4: Add Jason suggestions # This is the commit message #5: Cleanup wire image # This is the commit message #6: wip # This is the commit message #7: Seperate the manual into seperate files This avoids needing to add page breaks into the markdown and makes most of the peices reusable. Things like the controller specs can be linked individually. # This is the commit message #8: Add troubleshooting section # This is the commit message #9: Write initial updated manual (DRAFT FOR REVIEW) # This is the commit message #10: Update "Developing on a separate computer" section of DEVELOPING.md # This is the commit message #11: Update BLUETOOTH.md to have useful info for a printed format # This is the commit message #12: Add docker-compose.yaml Edit for reviewer inputs # This is the commit message #13: Edit for reviewer input # This is the commit message #14: Comment out SVGs, generate PDF for copy-editing # This is the commit message #15: Remove EDIT EDIT EDIT Replace QR codes # This is the commit message #16: Replace main unit panel images Stylize title, correct date on front page # This is the commit message #17: Correct formatting in TROUBLESHOOTING.md Remove incorrect information about the back panel from MAIN_CONTROLLER.md
SteveMicroNova
pushed a commit
that referenced
this pull request
May 9, 2024
# This is the 1st commit message: Add very basic user manual Still need to explore how to integrate latex commands invisibly # This is the commit message #2: Small layout updates before adding images # This is the commit message #3: Add a bunch of images # This is the commit message #4: Add Jason suggestions # This is the commit message #5: Cleanup wire image # This is the commit message #6: wip # This is the commit message #7: Seperate the manual into seperate files This avoids needing to add page breaks into the markdown and makes most of the peices reusable. Things like the controller specs can be linked individually. # This is the commit message #8: Add troubleshooting section # This is the commit message #9: Write initial updated manual (DRAFT FOR REVIEW) # This is the commit message #10: Update "Developing on a separate computer" section of DEVELOPING.md # This is the commit message #11: Update BLUETOOTH.md to have useful info for a printed format # This is the commit message #12: Add docker-compose.yaml Edit for reviewer inputs # This is the commit message #13: Edit for reviewer input # This is the commit message #14: Comment out SVGs, generate PDF for copy-editing # This is the commit message #15: Remove EDIT EDIT EDIT Replace QR codes # This is the commit message #16: Replace main unit panel images Stylize title, correct date on front page # This is the commit message #17: Correct formatting in TROUBLESHOOTING.md Remove incorrect information about the back panel from MAIN_CONTROLLER.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various changes to update the api and make group support more robust: