-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add airplay2 build of shairport-sync for testing #378
Conversation
Codecov Report
@@ Coverage Diff @@
## main #378 +/- ##
==========================================
- Coverage 56.81% 55.75% -1.07%
==========================================
Files 12 12
Lines 2920 2920
==========================================
- Hits 1659 1628 -31
- Misses 1261 1292 +31
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
At the moment we have one working Airplay 2 Stream, without metadata support. Supporting a single airplay 2 stream is looking very promising. NOTE: Multiple Airplay 2 streams will require a significant effort and some experimentation to integrate docker audio streams into our ALSA configuration and is not part of this PR. |
One option to support multiple Airplay 2 instances sans docker may be to use MVLAN in bridged mode, spinning up one virtual LAN per airplay 2 instance (or just having 4 default ones instantiated at boot time). Need to investigate how feasible this is and if multiple NQPTP servers can be run like this. |
Co-authored-by: Lincoln Lorenz <lincoln@micro-nova.com>
Use Spotifyd instead of vollibrespot to get latest librespot changes
- Add shairtunes dependency - Uses hash of the lms client name to get a unique "MAC Address" for lms - Server url is configurable. Use localhost when amplipi is the server
This stabilizes LMS MAC addresses over restarts.
Add LMS client, no metadata
We should probably wrap this PR soon. I think there are a couple of routes to finish this, since we can only support 1 airplay2 stream right now:
|
Satisfy mypy checks for unspecified optional and untyped functions
Hey, I know this is an old comment and you may have already made a decision, but I strongly endorse releasing option 1 for now, and backlogging support for options 2 and 3. There's a huge advantage to having even one airplay 2 stream, for home theater users and for people trying to explain to family and friends why playing from iPhones is "all weird and slow". Thanks in advance, and thanks a million times for all your work up to this point. |
We are actually working on a simple version of 2 right now with the plans of getting a prerelease out soon. |
Closing this since this work is being finalized in airplay1and2 |
Steps to add support for a single fully featured airplay2 stream