-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Spotifyd instead of vollibrespot to get latest librespot changes #366
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Lets test it.
I can help you add the installer for this in scripts/configure.py
when we get there.
Note most of those changes are only tangentally related to your PR just leftover things to clean up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way to download or build the spotifyd
binary at install time, instead of adding to the repo?
data = data.replace('5030', f'{self.metaport}') | ||
data = data.replace('device_name_in_spotify_connect', f'{self.name}') | ||
data = data.replace("alsa_audio_device", f"ch{src}") | ||
data = data.replace('1234', f'{self.connect_port}') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be awesome to expose bitrate
and autoplay
to the user if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we support higher bit rates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do this in the future when we are able to better characterize utilization. We still need a 4th Spotify account!
Lets test this on Jason's house and see how we like it now that this has gotten past the multiple account crash bug. |
Codecov Report
@@ Coverage Diff @@
## develop #366 +/- ##
===========================================
- Coverage 56.81% 54.98% -1.83%
===========================================
Files 12 13 +1
Lines 2920 3039 +119
===========================================
+ Hits 1659 1671 +12
- Misses 1261 1368 +107
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This needs to be rebased on develop to get the hotfix for uvicorn |
Is this ready without volume adjustment? |
I need to change the cache directory, keep forgetting. I'll do it Monday then rebase and we can merge. |
Co-authored-by: Lincoln Lorenz <lincoln@micro-nova.com>
Use Spotifyd instead of vollibrespot to get latest librespot changes
No description provided.