Repository navigation
[Fusion] Reject empty authorization groups in source schemas - #27
Merged
Merged
Conversation
michaelstaib
added this pull request to stack #28
October 5, 2026 17:35
michaelstaib
force-pushed
the
mst/auth-reject-empty-groups
branch
2 times, most recently
from
October 5, 2026 23:01
41c265f to
63a687f
Compare
michaelstaib
force-pushed
the
mst/auth-reject-empty-groups
branch
from
October 6, 2026 04:01
63a687f to
74780e1
Compare
michaelstaib
force-pushed
the
mst/auth-reject-empty-groups
branch
2 times, most recently
from
October 6, 2026 17:04
800ab7b to
e94b468
Compare
michaelstaib
force-pushed
the
mst/auth-reject-empty-groups
branch
from
October 6, 2026 17:08
e94b468 to
961d427
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: hc-fork-2-hdw.5 (Reject empty authorization groups in source schemas)
Stacked on #26. This PR's diff is against
mst/auth-federation-intake.An empty AND group is satisfied by anyone, so it would let every caller through.
AuthorizationDirectiveArgumentRulenow rejects these withINVALID_AUTHORIZATION_DIRECTIVE_ARGUMENT:This covers
@requiresScopesand@policyon fields and types, and Apollo intake hits the same rule.AuthorizationGroups.Reduceno longer skips empty factors.Also carried from the #26 review:
Verified:
dotnet build src/All.slnx: 0 errors.Minor review notes, not fixed:
INVALID_AUTHORIZATION_DIRECTIVE_ARGUMENTis an error but is listed in the Warnings table of composition.md. That came from [Fusion] Merge the source authorization directives into fusion__authorization #25.ParseGroupshas no fallback guard if the rule is ever bypassed.