Repository navigation
[Fusion] Rewrite Apollo Federation authorization directives into the Fusion source directives - #26
Merged
Conversation
michaelstaib
added this pull request to stack #28
October 5, 2026 17:35
michaelstaib
force-pushed
the
mst/auth-federation-intake
branch
4 times, most recently
from
October 6, 2026 05:29
58769a2 to
3761155
Compare
…Fusion source directives
michaelstaib
force-pushed
the
mst/auth-federation-intake
branch
from
October 6, 2026 17:04
3761155 to
f8b8b93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: hc-fork-2-hdw.2 (Federation intake rewrite for auth directives)
Stacked on #25. This PR's diff is against
mst/auth-composition-merger.TransformAuthDirectivesToFusionstep. It rewrites Apollo@authenticated,@requiresScopesand@policyinto the Fusion source directives on the same member, then strips the Apollo definitions.@linkimports, including federation 2.5+ namespaces,asrenames and renamed imports.ScopeandPolicyliteral is read, and the group structure is kept.@composeDirectiveis still rejected.FusionBuiltIns.SourceSchemaDirectivesand ignored if the source schema declares its own.Verified:
asrenames throughSchemaComposerin a scratch probe.Not verified:
dotnet build src/All.slnx, and federation v1 subgraphs.Minor review notes, not fixed:
@policyand the other two names are treated as auth directives even when they are not imported. This fails closed, and I sent it to the planner.SchemaComposertest uses Apollo-printed SDL; the probe covered it.