Skip to content

Add PR template (With changes) #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wirthual merged 2 commits into from
Oct 27, 2024
Merged

Add PR template (With changes) #441

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca06d3b
Create pull_request_template.md
fadkeabhi Oct 25, 2024
a2a3c4a
Merge branch 'main' into pull-request-template-create
fadkeabhi Oct 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
## Description
Please provide a clear and concise description of the changes in this PR.

## Related Issue
If applicable, link the issue this PR addresses.

## Types of Change
- [ ] Bug fix
- [ ] New feature
- [ ] Documentation update

## Checklist
- [ ] I have read the [CONTRIBUTING](https://github.com/michaelfeil/infinity/tree/main?tab=readme-ov-file#contribute-and-develop) guidelines.
Copy link
Contributor

@greptile-apps greptile-apps bot Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: The CONTRIBUTING link points to the readme tab which may break. Consider using direct link to contribution.md instead

- [ ] My code follows the code style of this project.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
Comment on lines +15 to +16
Copy link
Contributor

@greptile-apps greptile-apps bot Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider adding '(if applicable)' to test-related items since some changes (like docs) don't need tests

- [ ] My changes generate no new warnings.
- [ ] I have updated the documentation accordingly.

## Additional Notes
Add any other context about the PR here.

## License
By submitting this PR, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/michaelfeil/infinity/blob/main/LICENSE).