Skip to content

Conversation

@fadkeabhi
Copy link
Contributor

Description

This PR adds new pull request and issue templates to project. The templates provide structured guidelines for contributors, ensuring that necessary information is included in PRs.
I had already opened a PR for same, but it had some issues. Now I have implemented changes suggested by @wirthual in current PR.

Old Pull Request

#417

Related Issue

#416

Type of Change

  • Bug fix
  • New feature
  • Documentation update

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have added tests to cover my changes. (Not applicable for documentation changes)
  • All new and existing tests passed. (Not applicable for documentation changes)
  • My changes generate no new warnings.
  • I have updated the documentation accordingly.

License

By submitting this PR, I confirm that my contribution is made under the terms of the MIT license.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR adds comprehensive issue and pull request templates to standardize contribution formats, including bug reports, feature requests, model additions, and general pull requests.

  • Added .github/pull_request_template.md with structured sections for description, changes, and MIT license confirmation
  • Added .github/ISSUE_TEMPLATE/bug-report.yml with detailed system info collection and reproduction steps
  • Added .github/ISSUE_TEMPLATE/feature-request.yml for capturing feature proposals and motivation
  • Added .github/ISSUE_TEMPLATE/new-model-addition.yml specifically for model implementation requests
  • Added .github/ISSUE_TEMPLATE/config.yml to enable blank issues alongside templates

1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

- [ ] Documentation update

## Checklist
- [ ] I have read the [CONTRIBUTING](https://github.com/michaelfeil/infinity/tree/main?tab=readme-ov-file#contribute-and-develop) guidelines.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: The CONTRIBUTING link points to the readme tab which may break. Consider using direct link to contribution.md instead

Comment on lines +15 to +16
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider adding '(if applicable)' to test-related items since some changes (like docs) don't need tests

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.18%. Comparing base (7328a6e) to head (a2a3c4a).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #441   +/-   ##
=======================================
  Coverage   79.18%   79.18%           
=======================================
  Files          41       41           
  Lines        3248     3248           
=======================================
  Hits         2572     2572           
  Misses        676      676           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wirthual wirthual merged commit e2f601d into michaelfeil:main Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants