Update fork #1
Merged
Update fork #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
install: add note to conda install C++ compiler
adding Network.py and StackVRT.py to CMake
add integratePS.py and change the default unwrapper to snaphu
+ fix typo in workflows.md + tops/stripmap2vrt: add metavar to -b/-B options for easy usage
Add a Codacy badge to README.md
Stack: update xml file path for .slc.full file if dir changed.
+ unwrapStack: add --unw_method option with default value of phass + integratePS: - add --unw_method option with default of None. - create run file for PU only if --unw_method is specified - change --coreg_slc_dir to optional since it's not currently used in the code yet (commented out). + workflows.md: update for unwrap and fix typo + evd/README: update link for Ansari et al. (2017, FRINGE)
This reverts commit 4e1bd5b.
integratePS/unwrapStack: add --unw_method option
fix typo and broken links in README files
+ remove empty top lines in tops/stripmap/uavsar2vrt.py while writing vrt files for SLC and geometry + add mising quote symbol while writing vrt file for geometry in tops2vrt.py
+ sequential: support --bbox vrt_file to grab the bounding box info from the vrt file via vrt_file2bbox() following Piyush's suggestion, besides --bbox Y0 Y1 X0 X1 + workflows: update accordingly to avoid typing the bbox again + Stack/ampdispersoin: add missing xml files using gdal2isce_xml.py in Stack.py and ampdispersion.py. os.sysmte() is used here for now, and should be updated with python function call after next ISCE release
+ remove gdal2isce_xml.py call from ampdispersion.py and sequential/Stack.py + comment out isceobj.Utils.ImageUtil.ImageLib.loadImage () call
support VRT file input for sequential --bbox
cmake cleanup
Update workflow docs
update install doc for Mac
STBAS - untested
FRInGE uses arma::index_min, added in Armadillo version 8.100 Fixes #31 Co-authored-by: Ryan Burns <rtburns-jpl@users.noreply.github.com>
I've changed geom_master to geom_reference to reflect the changes with respect to ISCE v2.4.
Update tops2vrt.py
+ change "import gdal" to "from osgeo import gdal" for all applicable scripts + unwrap_fringe.py: write xml file for conncmp file
…SLC VRT generation
Fix tops2vrt script
Revert tops2vrt changes
* add plotCoherence.py * change the description to match what the script does * reformatting the script with black * cleaning up to address codacy * more cleanup * add line between summary and description Co-authored-by: Heresh Fattahi <fattahi@SNA-DGX-N01.jpl.nasa.gov>
* adding a new requirement yaml file * enforce cython from conda * modify ci config to work with new environment file * remove the old requirement file * rename environment file * fix ci config to point to environment file * turn the order of cython back Co-authored-by: Heresh Fattahi <hersh.fattahi@gmail.com>
* Added extracting info from xml file Extract info from xml file to determine the wavelength, earth radius and altitude * Edited code to used reference.xml info during unwrapping with SNAPHU * Removed unnsecessary info in extractInfo function * Removed double import of isce and isceobj libraries * Changes to code to incorporate reference xml file * Changes to code to incorporate reference xml file * Edited the workflow so there is only one unwrapper to be chosen * Run unwrapStack.py even if inps.xmlFile is not present * Run integratePS.py even if inps.xmlFile is not present * Corrected some bugs on the code * Removed trailing whitespace as suggested by codacy * Commented out codes deemed unnecessary by codacy
A fix is to set the metadata variable to None when no metadata XML file is found. This should fix the bug in unwrap_fringe.py, which would fail if using the SNAPHU unwrapper without the XML metadata file.
This lets you keyboard interrupt the unwrap script. Without the stop on error from `set -e`, you have to hold it while it tries to start each new snaphu process.
* unit test for evd run fringe evd and mle on simulated data and estimate rmse check the results reformat test_evd turn off plot add more comments add the unit test to the ci * ensure homogeneous neighborhood * fix minor codacy styles * plot before assert * remove extra empty line * address most style comments
* Mark inline functions Functions defined in headers must be marked `inline` to avoid multiple definition linker errors * Simplify toplevel CMake, require pybind11 * Convert evdlib to pybind11 * Add pybind11 requirement to docs/CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.