Fix tops2vrt script #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SLC VRT generation
hfattahi
reviewed
Jul 21, 2021
python/tops2vrt.py
Outdated
| ###Get ann list and slc list | ||
| slclist = glob.glob(os.path.join(inps.indir,'SLC','*','*.slc.full')) | ||
| # Get a list of co-registered full SLC VRTs | ||
| slclist = glob.glob(os.path.join(inps.indir, 'SLC', '*', '*.slc.full.vrt')) |
Contributor
There was a problem hiding this comment.
How about making "SLC" and ".slc.full.vart" also input arguments with default values as we have here?
In principle any slc that is readable by GDAL should work down the line with fringe core modules.
python/tops2vrt.py
Outdated
| print('write vrt file for stack directory') | ||
|
|
||
| # Allocate wavelength for Sentinel | ||
| wavelength = 0.05546576 |
Contributor
There was a problem hiding this comment.
I know it has been there from before. Would you please make this an input argument default to Sentinel-1 wavelength.
python/tops2vrt.py
Outdated
| os.path.join(inps.indir, | ||
| 'geom_reference', | ||
| val + '.rdr.full.vrt')), | ||
| linewidth=width * 8)) |
Contributor
There was a problem hiding this comment.
To increase readability shall we define a variable (e.g, PixelOffset=8 # bytes) and then change this line to
linewidth=width * PixelOffset))
piyushrpt
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ISCE2 Sentinel stack processor generates a VRT file for each of the secondary co-registered SLC of the processed stack. Each VRT points to the individual bursts forming the single co-registered SLC.
At the moment, the script
tops2vrt.pylooks for the binary files of full/merged co-registered SLCs of the stack and tries to generate VRT files out of them. This step is not necessary, as the VRT generation for the full secondary co-registered SLCs is already taken into account by the ISCE2 Sentinel stack processor. Also, whentops2vrt.pylooks for the binaries of the co-registered secondary SLCs, no SLC is found.This PR removes the individual full-coregistered SLC VRT generation from
tops2vrt.py. Instead, the VRT stack file (slcs_base.vrt) is generated to directly pointing to the VRTs of the individual full-coregistered secondary SLCs generated by the ISCE2 stack processor.The PR also: