fix: #443 useSyncEffect Breaks useFind Reactivity Under Suspense#438
Merged
nachocodoner merged 1 commit intometeor:masterfrom Apr 16, 2025
welkinwong:master
Merged
fix: #443 useSyncEffect Breaks useFind Reactivity Under Suspense#438nachocodoner merged 1 commit intometeor:masterfrom welkinwong:master
nachocodoner merged 1 commit intometeor:masterfrom
welkinwong:master
Conversation
Contributor
Author
|
In the client-side implementation of suspense/useFind, useFindClient is used. PR #433 introduced useSyncEffect. Nevertheless, when used in Strict Mode and with Suspense, the useSyncEffect implementation results in non-trivial and hard-to-predict issues. As a result, the Suspense-enabled useFindSuspenseClient will no longer reference useFindClient and will instead be a standalone implementation (derived from the last stable version of useFindClient).
Member
|
I found an infinite render loop error while testing the new beta of react-meteor-data. It happens in a use case with Suspense. I'd like to check if this update fixes it.
|
Member
|
Merging this since I confirm the fix. Will publish a beta soon. Thanks a lot for the detailed PRs and focus on these issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the client-side implementation of
suspense/useFind, useFindClient is used. PR #418 introduceduseSyncEffect.Nevertheless, when used in Strict Mode and with Suspense, the
useSyncEffectimplementation results in non-trivial and hard-to-predict issues.As a result, the Suspense-enabled
useFindSuspenseClientwill no longer referenceuseFindClientand will instead be a standalone implementation (derived from the last stable version ofuseFindClient).Note: The #418 test case issue does not occur with React 18/19's
createRootwhen usingSuspense(the test passes normally in this configuration).