Fix concurrency issue with useFind (Contribution)#433
Merged
nachocodoner merged 7 commits intomasterfrom Apr 3, 2025
Merged
Conversation
Thank you for your review ! Code looks cleaner :) Co-authored-by: Notas Hellout <5165674+make-github-pseudonymous-again@users.noreply.github.com>
…usefind # Conflicts: # packages/react-meteor-data/useFind.ts
|
Johan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
|
@nachocodoner i signed it but with another email |
italojs
pushed a commit
that referenced
this pull request
Jun 11, 2025
In the client-side implementation of suspense/useFind, useFindClient is used. PR #433 introduced useSyncEffect. Nevertheless, when used in Strict Mode and with Suspense, the useSyncEffect implementation results in non-trivial and hard-to-predict issues. As a result, the Suspense-enabled useFindSuspenseClient will no longer reference useFindClient and will instead be a standalone implementation (derived from the last stable version of useFindClient).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues: #428 and #419
Verifying the fix provided with the test facilitated so that we can merge it already and make it available for next beta of the package. This branch is a way for us to do the verifications before merging to base branch.