-
Notifications
You must be signed in to change notification settings - Fork 74
Replace src/ios/GCDWebServer with git submodule. #45
Conversation
Much better indeed 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as well!
Might be nice to commit the "current" state of GCDWebserver to a branch in the new (forked) repository, so we can see any differences. |
The modified GCDWebserver in this repository, that is. |
I've published this version to npm as |
I'm curious if developers will experience problems installing this plugin from a Git URL, ala:
...will encounter problems since Cordova bundles Anyhow, just a thought. |
I just tried creating and running a brand new app:
using
This prevented the app from running. This is the same error that was reported in #34. Is anyone else seeing this? I'll keep debugging to see if it's just an issue with my environment, but just a heads up. |
I'm also having this problem (in 1.6.0). It's holding us back from deploying my meteor app to the ios app store. It's critical for us. |
It's much easier to maintain a fork of https://github.com/swisspol/GCDWebServer (that is, https://github.com/meteor/GCDWebServer) and include it in this repository as a submodule, potentially with additional commits cherry-picked in, than to maintain a copy of the code within this repository.