Skip to content
This repository was archived by the owner on Oct 2, 2021. It is now read-only.

Replace src/ios/GCDWebServer with git submodule. #45

Merged
merged 3 commits into from
Jan 17, 2018

Conversation

benjamn
Copy link
Contributor

@benjamn benjamn commented Jan 17, 2018

It's much easier to maintain a fork of https://github.com/swisspol/GCDWebServer (that is, https://github.com/meteor/GCDWebServer) and include it in this repository as a submodule, potentially with additional commits cherry-picked in, than to maintain a copy of the code within this repository.

@KoenLav
Copy link

KoenLav commented Jan 17, 2018

Much better indeed 👍

Copy link
Contributor

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well!

@KoenLav
Copy link

KoenLav commented Jan 17, 2018

Might be nice to commit the "current" state of GCDWebserver to a branch in the new (forked) repository, so we can see any differences.

@KoenLav
Copy link

KoenLav commented Jan 17, 2018

The modified GCDWebserver in this repository, that is.

@benjamn benjamn merged commit 9ea468e into master Jan 17, 2018
@benjamn
Copy link
Contributor Author

benjamn commented Jan 17, 2018

I've published this version to npm as cordova-plugin-meteor-webapp@1.5.0, in case anyone wants to play with it (just edit meteor/packages/webapp/package.js to change the version).

@abernix
Copy link
Contributor

abernix commented Jan 18, 2018

I'm curious if developers will experience problems installing this plugin from a Git URL, ala:

meteor add cordova:cordova-plugin-meteor-webapp@https://github.com/...

...will encounter problems since Cordova bundles npm@2 prior to Cordova 8 (which Meteor has yet to jump to) and Git submodule support was less robust (missing?) in those earlier (read: old) versions of npm. Even if this is the case, it will hopefully be temporary since as of Cordova 8 it no longer bundles npm and falls back to the "system npm", which in Meteor's case, should be "Meteor's version of npm".

Anyhow, just a thought.

@hwillson
Copy link
Contributor

hwillson commented Jan 18, 2018

I just tried creating and running a brand new app:

meteor create mobile-test
meteor add-platform ios
meteor run ios-device

using cordova-plugin-meteor-webapp@1.5.2 and the devel branch, and was immediately hit with the following error:

Could not signal service com.apple.WebKit.WebContent: 113: Could not find specified service

This prevented the app from running. This is the same error that was reported in #34. Is anyone else seeing this? I'll keep debugging to see if it's just an issue with my environment, but just a heads up.

@abernix abernix mentioned this pull request Jan 24, 2018
@iwoj
Copy link

iwoj commented Jul 21, 2018

I'm also having this problem (in 1.6.0). It's holding us back from deploying my meteor app to the ios app store. It's critical for us.

@filipenevola filipenevola deleted the replace-GCDWebServer-copy-with-submodule branch January 16, 2020 15:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants