Feature/restart gcd webserver

[macrozone]

applies swisspol/GCDWebServer#299 as well as #25

and fixes #27

I just copied the source code from swisspol/GCDWebServer#299 into this project, not sure if this has some kind of dependency management?

you can install and try this fix with:

cordova-plugin-meteor-webapp@https://github.com/panter/cordova-plugin-meteor-webapp.git#7bb095ce393d17f662cc6bb596ce91acf743d17a

meteor 1.6.1 users use: cordova-plugin-meteor-webapp@https://github.com/panter/cordova-plugin-meteor-webapp.git#574e11822890a773cc307ab068e1c745384c80a2 (carefull this version is NOT compatible with meteor < 1.6.1) (this has been fixed in meteor 1.6.1)

[Wade-BuildOtto]

so far so good, I opened my app this morning and it opened up quicker then I have ever seen, like it was ready to use, few more days of trials and I think we can call this fixed.

crossing fingers,
Thank you so much,

[macrozone]

crossing fingers too, had also no problem anymore ;-)

[abernix]

@macrozone Thank you very much for taking a look at this. I would love to get this reviewed, merged and released, possibly in Meteor 1.5.2 and along with other Cordova updates.

That said, it would be substantially easier to review this pull request (which must be reviewed carefully, in its entirety) if it was broken down a lot more. As of right now this is a bit daunting and slightly risky.

The PR you linked to is quite a bit more brief. Maybe a better approach here would be to apply the incremental changes (which have likely been made to the master repository over a longer period of time?) automatically (for example, using git apply or git am with the -p argument to apply all their patches to the GCDWebServer directory). This would bring this repository up to date, while preserving the logical commits and changes from the Git history, and then we could apply this last (outstanding PR)?

Alternatively, it would be far easier to review this if:

• Formatting (whitespace, new-lines, etc.) changes were submitted in a separate PR (They are valuable, and I'm happy to accept them, but even with GitHub's ?w=1 query parameter (which tries to ignore whitespace changes), there is a lot of non-functionality change in here.
• Specific functional changes were in separate commits.

As you may not have been the one who added all the formatting and other functionality changes, the previous approach I suggested may be more reasonable.

Thoughts?

[macrozone]

@abernix yeah, it's still "make it run make it right make it fast", i just copied the code.

I try to give my best to do this cleaner, but i have to familiarize myself with these advanced git workflows.

I would suggest to first review & merge #25

as I also included this. So I could focuse on applying the gcd-webserver fixes

[abernix]

@macrozone Any updates on this?

I ask as I'd love to get this into Meteor 1.5.2!

[abernix]

Assuming my changes from #31 work okay, this can be rebased on that and evaluated much more efficiently – though it would still be great if swisspol/GCDWebServer#299 could get the blessing of the original author and be officially merged!

[macrozone]

@abernix I will give it a try this week, stay tuned.

[dylanjaye]

Just wanted to confirm this fix. I was having issues with Meteor failing to load resources on iOS after locking the screen.

Incorporating this cordova plugin: cordova-plugin-meteor-webapp@https://github.com/panter/cordova-plugin-meteor-webapp.git#7bb095ce393d17f662cc6bb596ce91acf743d17a

as suggested by @macrozone has completely fixed my issue. +1

[Nauzer]

@abernix @macrozone how is it looking? Any chance this might get into 1.5.2?
Since 1.5.2 is a minor version can it contain cordova plugin updates?

[macrozone]

@Nauzer we should merge #31 first and then apply swisspol/GCDWebServer#299

it would be easier if swisspol/GCDWebServer#299 would be merged in the original repository though, so maybe you leave an upvote there ;-)

[KoenLav]

@macrozone could you implement your changes (not to GCD webserver, but to the Meteor specific code) into a branch based off this one: https://github.com/meteor/cordova-plugin-meteor-webapp/tree/replace-GCDWebServer-copy-with-submodule ?

Please note that the commit 'Making compatible with Meteor 1.6.1' is no longer required (this has been fixed in Meteor itself).

[benjamn]

@macrozone Do you think you could rebase the key changes in this PR against the current master branch (version 1.5.2), bearing in mind that src/ios/GCDWebServer is now a git submodule (#45)?

Edit: sorry that's the same request @KoenLav just made… 😝

[KoenLav]

@benjamn I created a PR which covers the changes made in GCDWebServer#299 here:

meteor/GCDWebServer#2

[macrozone]

sorry guys, i was skiing in the mountains ;-)

@KoenLav, i can test it in the next week, but from the code, it looks clean to me.

[KoenLav]

@macrozone any progress?

[KoenLav]

@macrozone do you think this PR still provides any value, or rather it should be closed?

[macrozone]

@KoenLav

The changes in this PR should have landet already in another PR