(chore) add clippy to candy machine #490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stegaBOB
requested review from
austbot,
blockiosaurus,
danenbm,
lorisleiva,
roederw,
samuelvanderwaal and
thlorenz
as code owners
stegaBOB
changed the title
samuelvanderwaal
previously approved these changes
May 26, 2022
roederw
previously approved these changes
May 27, 2022
thlorenz
suggested changes
May 30, 2022
There was a problem hiding this comment.
If you could please update anchor and get the IDL fixed to include errors so we can generate those again with solita.
Also you should probably run the generator in any case + include with this PR(unless the IDL just got reordered and results in same generated code).
I'm fine if the anchor upgrade needs to happen in a separate PR and will approve if this is too tricky to include here.
| @@ -0,0 +1,313 @@ | |||
| use std::str::FromStr; | |||
There was a problem hiding this comment.
I like those helpers.
Maybe it's time to pull those into a separate crate we can use all over?
Maybe sol-test-utils or something like that for the solana core specific ones?
And mp-test-utils for the ones involving metaplex programs?
KirillLykov
pushed a commit
to KirillLykov/metaplex-program-library
that referenced
this pull request
Jul 4, 2023
…ix/build-analytics fix: build analytics page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big IDL diff only because the items were reordered to match the actual rust file. The JSON file is identical. the order was initially changed to ensure the diff was small for #418