Enforce Collections w/ CM and clean up code #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stegaBOB
requested review from
austbot,
blockiosaurus,
danenbm,
lorisleiva,
roederw,
samuelvanderwaal and
thlorenz
as code owners
… into stegaBOB/enforce-cm-collections
# Conflicts: # candy-machine/program/Cargo.lock # candy-machine/program/Cargo.toml # candy-machine/program/src/lib.rs # candy-machine/program/src/utils.rs
… into stegaBOB/enforce-cm-collections
This was referenced May 5, 2022
roederw
reviewed
May 6, 2022
austbot
suggested changes
May 6, 2022
|
We will need to announce the idl change |
|
There's basically no IDL change. What we need to announce more is the enforcement of the collections |
danenbm
previously approved these changes
May 17, 2022
… into stegaBOB/enforce-cm-collections
samuelvanderwaal
previously approved these changes
May 20, 2022
… into stegaBOB/enforce-cm-collections
austbot
approved these changes
May 23, 2022
| - 'core/**' | ||
| package: | ||
| - 'candy-machine/**' | ||
| build-lint-and-test-auction: |
There was a problem hiding this comment.
you don't need to do all this in one step consider breaking up in the future
| wallet: this.wallet.toBase58(), | ||
| tokenMint: this.tokenMint, | ||
| itemsRedeemed: this.itemsRedeemed, | ||
| itemsRedeemed: (() => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps anchor version, fixes Clippy issues, splits up huge file into multiple byte sized chunks.
Also uses the currently unused UUID as a sentinel to check if a collection has been set.