Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/config: Replace k8s.io/utils/strings/slices by Go stdlib slices #2583

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

tklauser
Copy link
Contributor

@tklauser tklauser commented Nov 6, 2024

Is this a BUG FIX or a FEATURE ?:

/kind cleanup

What this PR does / why we need it:

Use the functionality provided by the Go standard library slices package since Go 1.21 instead of the deprecated functions in the k8s.io/utils/strings/slices package.

Special notes for your reviewer:

Release note:

NONE

Use the functionality provided by the Go standard library slices package
since Go 1.21 instead of the deprecated functions in the
k8s.io/utils/strings/slices package.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@fedepaol
Copy link
Member

fedepaol commented Nov 6, 2024

Thanks! Sending to merge queue.
How did you find this, out of curiosity?

@tklauser
Copy link
Contributor Author

tklauser commented Nov 6, 2024

Thanks! Sending to merge queue. How did you find this, out of curiosity?

I did the original change in k8s.io/utils/strings/slices deprecating most of the functions (see kubernetes/utils#315) and now checked for prominent importers of the package here: https://pkg.go.dev/k8s.io/utils/strings/slices?tab=importedby

@fedepaol
Copy link
Member

fedepaol commented Nov 6, 2024

Thanks! Sending to merge queue. How did you find this, out of curiosity?

I did the original change in k8s.io/utils/strings/slices deprecating most of the functions (see kubernetes/utils#315) and now checked for prominent importers of the package here: https://pkg.go.dev/k8s.io/utils/strings/slices?tab=importedby

ah TIL about importedby! Thanks again

@fedepaol fedepaol merged commit 84a5a5d into metallb:main Nov 6, 2024
31 checks passed
@tklauser tklauser deleted the stdlib-slices branch November 6, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants