Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate strings/slices functions covered by stdlib slices #315

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

tklauser
Copy link
Contributor

@tklauser tklauser commented Aug 20, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

As suggested by @thockin in [1], deprecate the functions in the k8s.io/utils/strings/slices package that are already covered by generic functions in the Go standard library slices package. Also reimplement them in terms of slices functions.

[1] kubernetes/kubernetes#126715 (review)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Release note:

Deprecate k8s.io/utils/strings/slices functions covered by the Go standard libary slices package.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 20, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @tklauser!

It looks like this is your first PR to kubernetes/utils 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/utils has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 20, 2024
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super minor point. Is the `use [other] instead" syntax documented somewhere?

strings/slices/slices.go Outdated Show resolved Hide resolved
@thockin thockin self-assigned this Aug 20, 2024
@tklauser
Copy link
Contributor Author

super minor point. Is the `use [other] instead" syntax documented somewhere?

The syntax is documented at https://go.dev/doc/comment#doclinks

As suggested by Tim in [1], deprecate the functions in the
k8s.io/utils/strings/slices package that are already covered by generic
functions in the Go standard library slices package. Also reimplement
them in terms of slices functions.

[1] kubernetes/kubernetes#126715 (review)
@thockin
Copy link
Member

thockin commented Aug 21, 2024

Cool.TIL. Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin, tklauser

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2024
@k8s-ci-robot k8s-ci-robot merged commit f90d014 into kubernetes:master Aug 21, 2024
2 checks passed
@tklauser tklauser deleted the deprecated-strings-slices branch August 21, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants