-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate strings/slices functions covered by stdlib slices #315
Deprecate strings/slices functions covered by stdlib slices #315
Conversation
Welcome @tklauser! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super minor point. Is the `use [other] instead" syntax documented somewhere?
The syntax is documented at https://go.dev/doc/comment#doclinks |
As suggested by Tim in [1], deprecate the functions in the k8s.io/utils/strings/slices package that are already covered by generic functions in the Go standard library slices package. Also reimplement them in terms of slices functions. [1] kubernetes/kubernetes#126715 (review)
01e27dd
to
4965b0f
Compare
Cool.TIL. Thanks! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thockin, tklauser The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
As suggested by @thockin in [1], deprecate the functions in the k8s.io/utils/strings/slices package that are already covered by generic functions in the Go standard library slices package. Also reimplement them in terms of slices functions.
[1] kubernetes/kubernetes#126715 (review)
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: