Skip to content

Conversation

@SebastianAment
Copy link
Contributor

@SebastianAment SebastianAment commented Aug 29, 2024

Summary:
Changing EI to LogEI in the iBNN tutorial.

Notably this anecdotally improves the performance of the Matern-GP BO substantially, even in this high-dimensional space:

Before After with LogEI
Screenshot 2024-08-28 at 4 06 44 PM Screenshot 2024-08-28 at 4 05 17 PM

Differential Revision: D61997648

Differential Revision: D61997651
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 29, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61997648

@codecov
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.98%. Comparing base (0b4942e) to head (dac25ae).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2499   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         193      193           
  Lines       16947    16947           
=======================================
  Hits        16945    16945           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SebastianAment and others added 3 commits August 29, 2024 15:29
…#2496)

Summary:
Pull Request resolved: meta-pytorch#2496

Updating the constrained noisy optimization tutorial to use LogEI, which improves the performance of both versions, and crystalizes the advantage of the `qLogNEI` in the noisy context:

Before:
{F1834686039}

After:
{F1834684434}

Differential Revision: D61997649

Reviewed By: esantorella
…pytorch#2498)

Summary:
Pull Request resolved: meta-pytorch#2498

Updating the analytic vs MC comparison tutorial to use LogEI.

Differential Revision: D61997650

Reviewed By: esantorella
Summary:
Pull Request resolved: meta-pytorch#2499

Changing EI to LogEI in the iBNN tutorial.

Notably this anecdotally improves the performance of the Matern-GP BO substantially, even in this high-dimensional space:
{F1834660285}

Reviewed By: esantorella

Differential Revision: D61997648
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61997648

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 1f6bf87.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants