Skip to content

Conversation

@SebastianAment
Copy link
Contributor

@SebastianAment SebastianAment commented Aug 29, 2024

Updating the constrained noisy optimization tutorial to use LogEI, which improves the performance of both versions, and crystalizes the advantage of the qLogNEI in the noisy context:

Before After with LogEI
Screenshot 2024-08-29 at 6 37 53 PM Screenshot 2024-08-29 at 6 37 25 PM

Differential Revision: D61997649

Differential Revision: D61997651
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 29, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61997649

@codecov
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.98%. Comparing base (0b4942e) to head (7b8b242).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2496   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         193      193           
  Lines       16947    16947           
=======================================
  Hits        16945    16945           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61997649

SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Aug 29, 2024
…#2496)

Summary:
Pull Request resolved: meta-pytorch#2496

Updating the constrained noisy optimization tutorial to use LogEI, which improves the performance of both versions, and crystalizes the advantage of the `qLogNEI` in the noisy context:

Before:
{F1834686039}

After:
{F1834684434}

Differential Revision: D61997649
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61997649

SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Aug 29, 2024
…#2496)

Summary:
Pull Request resolved: meta-pytorch#2496

Updating the constrained noisy optimization tutorial to use LogEI, which improves the performance of both versions, and crystalizes the advantage of the `qLogNEI` in the noisy context:

Before:
{F1834686039}

After:
{F1834684434}

Reviewed By: esantorella

Differential Revision: D61997649
SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Aug 29, 2024
…#2496)

Summary:
Pull Request resolved: meta-pytorch#2496

Updating the constrained noisy optimization tutorial to use LogEI.

Differential Revision: D61997649
…#2496)

Summary:
Pull Request resolved: meta-pytorch#2496

Updating the constrained noisy optimization tutorial to use LogEI, which improves the performance of both versions, and crystalizes the advantage of the `qLogNEI` in the noisy context:

Before:
{F1834686039}

After:
{F1834684434}

Reviewed By: esantorella

Differential Revision: D61997649
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61997649

SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Aug 29, 2024
…#2496)

Summary:
Pull Request resolved: meta-pytorch#2496

Updating the constrained noisy optimization tutorial to use LogEI, which improves the performance of both versions, and crystalizes the advantage of the `qLogNEI` in the noisy context:

Before:
{F1834686039}

After:
{F1834684434}

Differential Revision: D61997649

Reviewed By: esantorella
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 136dc11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants