Skip to content

Conversation

@WillAyd
Copy link
Contributor

@WillAyd WillAyd commented May 19, 2025

This is a pre-cursor to add support for Apache Arrow in #2099

@WillAyd WillAyd force-pushed the add-gflags-wrap branch from 2236fd8 to c8c8d79 Compare May 19, 2025 15:50
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This creates a subdirectory src/gflags that doesn't exist in the upstream repo, which works but is a bit confusing. Since everything here specifies install_dir: 'gflags', is that actually needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC the configure_file calls in the CMake configuration create the header files in:

"${PROJECT_BINARY_DIR}/include/${GFLAGS_INCLUDE_DIR}

where the GFLAGS_INCLUDE_DIR is by default set to the name of the package itself. I also am of the understanding that Meson does not give you the control to choose a different build directory to write a configured file into, but that it instead infers it from the location of the meson.build file in the source tree.

So this is a bit of a compromise where we place this configuration somewhere in the source tree so that the default include search patch will still resolve to gflags/<configured_file>.h, but there may be a better way to handle that

@WillAyd WillAyd force-pushed the add-gflags-wrap branch from c8c8d79 to 2e7abb9 Compare May 27, 2025 17:00
@bgilbert bgilbert merged commit 4661086 into mesonbuild:master Jun 2, 2025
15 checks passed
@WillAyd WillAyd deleted the add-gflags-wrap branch June 2, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants