-
Notifications
You must be signed in to change notification settings - Fork 267
gflags: Add new wrap #2114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gflags: Add new wrap #2114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This creates a subdirectory src/gflags that doesn't exist in the upstream repo, which works but is a bit confusing. Since everything here specifies install_dir: 'gflags', is that actually needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC the configure_file calls in the CMake configuration create the header files in:
"${PROJECT_BINARY_DIR}/include/${GFLAGS_INCLUDE_DIR}
where the GFLAGS_INCLUDE_DIR is by default set to the name of the package itself. I also am of the understanding that Meson does not give you the control to choose a different build directory to write a configured file into, but that it instead infers it from the location of the meson.build file in the source tree.
So this is a bit of a compromise where we place this configuration somewhere in the source tree so that the default include search patch will still resolve to gflags/<configured_file>.h, but there may be a better way to handle that
This is a pre-cursor to add support for Apache Arrow in #2099